Summary:ASTERISK-23730: [patch] Blind transfers are not logged into queue_log
Reporter:David Guerrero (davidguerrero)Labels:patch
Date Opened:2014-05-09 04:29:02Date Closed:
Versions: 11.8.1 12.2.0 13.18.4 Frequency of
is caused byASTERISK-13635 [patch] After a caller is processed by app_queue the queue_log logs the hangup as TRANSFER
is related toASTERISK-17658 [patch] [regression] Blind transfers from queue are not logged into queue_log correctly
Environment:Linux x64Attachments:( 0) app_queue.patch
Description:When a call in a queue is transfered via "blind transfer" (DTMF sequence) by an agent, the transfer is always logged the queue_log file as "COMPLETECALLER", instead of "TRANSFER".

This incorrect behaviour (regression) was introduced in 1.6 version, and was noted in issued ASTERISK-17658, and a patch proposed. For some reason (inactivity) the issue was autoclosed without a fix.

With updated syntax, line 5932 in app_queue.c should change to:

if (strcasecmp(oldcontext, ast_channel_context(qe->chan)) || strcasecmp(oldexten, ast_channel_exten(qe->chan))) {

to properly detect a blind transfer.

Now, it works as expected.

Comments:By: Matt Jordan (mjordan) 2014-05-15 20:59:56.029-0500

Thanks for the patch - you may want to post it up to review board [1] for a more formal peer review.

[1] https://wiki.asterisk.org/wiki/display/AST/Code+Review

By: Matt Jordan (mjordan) 2014-05-15 21:04:35.889-0500

Just as an aside - before r211957 is reverted, we'd have to be very sure that we aren't re-introducing the bug in ASTERISK-13635.