| Summary: | ASTERISK-17658: [patch] [regression] Blind transfers from queue are not logged into queue_log correctly | ||||||||
| Reporter: | Grzegorz Garlewicz (garlew) | Labels: | |||||||
| Date Opened: | 2011-04-07 12:10:26 | Date Closed: | 2012-04-24 14:52:42 | ||||||
| Priority: | Major | Regression? | Yes | ||||||
| Status: | Closed/Complete | Components: | Applications/app_queue | ||||||
| Versions: | 1.8.7.0 | Frequency of Occurrence | Constant | ||||||
| Related Issues: |
| ||||||||
| Environment: | Attachments: | ( 0) app_queue.diff | |||||||
| Description: | In 1.4 blind transfers from queue were correctly logged as TRANSFER. starting with 1.6.x they are no more logged as TRANSFER but as COMPLETEAGENT. I believe this is a regression related to issue 0014536. This was a fix for 1.4 merged into 1.6. It adds a test condition: !(qe->chan->_softhangup | peer->_softhangup). But in 1.4 peer->_softhangup was 1 during blind transfer and in 1.6.2 up peer->_softhangup is 0. This results in dead code for blind transfer logging. The trivial fix would be to revert 0014536-related changes (patch included) because when following issue pattern from 0014536 in 1.6.2 up this condition is no longer even tested. The remaining question is if it is ok that peer->_softhangup is now 0. | ||||||||
| Comments: | By: Grzegorz Garlewicz (garlew) 2011-04-07 12:13:18 Trivial fix for 1.8 SVN included By: Grzegorz Garlewicz (garlew) 2011-05-27 12:45:14 As this is a regression it might be worth fixing for the last 1.6.2 version. By: Richard Mudgett (rmudgett) 2011-07-06 10:48:27.752-0500 Can you show this incorrect logging and how to reproduce? I am not able to reproduce this problem. What blind transfer method are you using? Features.conf (DTMF) or SIP? Does it still happen with 1.8.5 or 1.8 SVN? The fix for ASTERISK-16874 may have fixed this as well. By: Richard Mudgett (rmudgett) 2011-07-26 13:37:55.829-0500 Any response? By: Leif Madsen (lmadsen) 2011-08-10 16:22:21.396-0500 Suspended due to lack of activity. Please request a bug marshal in #asterisk-bugs on the IRC network irc.freenode.net to reopen the issue should you have the additional information requested. Further information can be found at http://www.asterisk.org/developers/bug-guidelines By: Leif Madsen (lmadsen) 2011-09-16 15:20:17.433-0500 Reopened per the reporter on IRC. By: Leif Madsen (lmadsen) 2011-09-16 15:20:30.985-0500 Requesting information from the reporter. By: Grzegorz Garlewicz (garlew) 2011-09-16 15:26:07.618-0500 I'm using SIP blind transfers. The issue is still present in 1.8.6 and as I can see nothing changed in svn either. By: Grzegorz Garlewicz (garlew) 2011-09-16 15:31:26.280-0500 To reproduce: after a call goes through a queue and is connected with agent, agent does blind transfer. In queue log it should be logged as TRANSFER (and it was back in 1.4) but it is logged as COMPLETEAGENT. By: Matt Jordan (mjordan) 2012-04-10 14:05:32.067-0500 We require a complete debug log to help triage the issue. This document will provide instructions on how to collect debugging logs from an Asterisk machine for the purpose of helping bug marshals troubleshoot an issue: https://wiki.asterisk.org/wiki/display/AST/Collecting+Debug+Information By: Matt Jordan (mjordan) 2012-04-24 14:52:37.248-0500 Suspended due to lack of activity. Please request a bug marshal in #asterisk-bugs on the IRC network irc.freenode.net to reopen the issue should you have the additional information requested. Further information can be found at http://www.asterisk.org/developers/bug-guidelines By: Denis (denisr) 2013-03-21 02:05:14.706-0500 TRANSFER still not shown in queue_log in 1.8.20.1 | ||||||||