[Home]

Summary:ASTERISK-26509: A few non-critical deprecation warnings when building on Ubuntu 16.10
Reporter:Jonathan Harris (lardconcepts)Labels:
Date Opened:2016-10-26 16:32:21Date Closed:2016-11-08 04:58:03.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Core/General
Versions:14.1.0 Frequency of
Occurrence		Constant
Related
Issues:
is related toASTERISK-26412 build: Prepare for gcc 6.2
Environment:Ubuntu 16.10 (GNU/Linux 4.8.0-26-generic x86_64)Attachments:
Description:Never noticed these before, but building 14.1.0 on Ubuntu 16.10 today, it threw these warnings:

{code}
  [CC] invert.c -> invert.o
invert.c: In function ‘invert_’:
invert.c:167:24: warning: array subscript is above array bounds [-Warray-bounds]
     rc[j] -= rc[k] * v[j + k * 10 - 11];
                      ~^~~~~~~~~~~~~~~~~
  [CC] irc2pc.c -> irc2pc.o

  [CC] stasis_recording/stored.c -> stasis_recording/stored.o
stasis_recording/stored.c: In function ‘find_recording’:
stasis_recording/stored.c:175:2: warning: ‘readdir_r’ is deprecated [-Wdeprecated-declarations]
 while (readdir_r(dir, &entry, &result) == 0 && result != NULL) {
 ^~~~~
In file included from stasis_recording/stored.c:34:0:
/usr/include/dirent.h:183:12: note: declared here
extern int readdir_r (DIR *__restrict __dirp,
           ^~~~~~~~~
stasis_recording/stored.c: In function ‘scan_dir’:
stasis_recording/stored.c:343:2: warning: ‘readdir_r’ is deprecated [-Wdeprecated-declarations]
 while (readdir_r(dir, &entry, &result) == 0 && result != NULL) {
 ^~~~~
In file included from stasis_recording/stored.c:34:0:
/usr/include/dirent.h:183:12: note: declared here
extern int readdir_r (DIR *__restrict __dirp,
           ^~~~~~~~~
  [LD] res_stasis_recording.o stasis_recording/stored.o -> res_stasis_recording.so

{code}

It still built and seems to run OK, just giving you a heads-up. Thanks!
Comments:By: Asterisk Team (asteriskteam) 2016-10-26 16:32:23.593-0500

Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution.

A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report.

Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].
By: Friendly Automation (friendly-automation) 2016-10-28 15:26:00.894-0500

Change 4222 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4222|https://gerrit.asterisk.org/4222]
By: Friendly Automation (friendly-automation) 2016-10-28 15:26:36.022-0500

Change 4223 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4223|https://gerrit.asterisk.org/4223]
By: Friendly Automation (friendly-automation) 2016-10-28 15:26:48.141-0500

Change 4224 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4224|https://gerrit.asterisk.org/4224]
By: Friendly Automation (friendly-automation) 2016-10-28 15:27:53.105-0500

Change 4222 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4222|https://gerrit.asterisk.org/4222]
By: Friendly Automation (friendly-automation) 2016-10-28 15:28:09.010-0500

Change 4223 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4223|https://gerrit.asterisk.org/4223]
By: Friendly Automation (friendly-automation) 2016-10-28 15:28:18.186-0500

Change 4224 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4224|https://gerrit.asterisk.org/4224]
By: Friendly Automation (friendly-automation) 2016-11-08 04:58:04.510-0600

Change 4223 merged by Joshua Colp:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4223|https://gerrit.asterisk.org/4223]
By: Friendly Automation (friendly-automation) 2016-11-08 04:58:15.306-0600

Change 4224 merged by Joshua Colp:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4224|https://gerrit.asterisk.org/4224]
By: Friendly Automation (friendly-automation) 2016-11-08 04:58:23.173-0600

Change 4222 merged by Joshua Colp:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4222|https://gerrit.asterisk.org/4222]
By: Friendly Automation (friendly-automation) 2017-01-27 16:50:42.127-0600

Change 4839 merged by George Joseph:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4839|https://gerrit.asterisk.org/4839]