[Home]

Summary:ASTERISK-26412: build: Prepare for gcc 6.2
Reporter:George Joseph (gjoseph)Labels:
Date Opened:2016-09-27 17:09:36Date Closed:2016-11-08 04:58:06.000-0600
Priority:MinorRegression?
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
is related toASTERISK-26509 A few non-critical deprecation warnings when building on Ubuntu 16.10
Environment:Attachments:
Description:gcc 6.2 generates more warnings.  need to eventually address.

Here's 1:

{noformat}
chan_dahdi.c: In function 'device2chan':
chan_dahdi.c:11952:2: warning: '__minor_from_sys_types' is deprecated:
 In the GNU C Library, `minor' is defined by <sys/sysmacros.h>.
 For historical compatibility, it is currently defined by
 <sys/types.h> as well, but we plan to remove this soon.
 To use `minor', include <sys/sysmacros.h> directly.
 If you did not intend to use a system-defined macro `minor',
 you should #undef it after including <sys/types.h>.
 [-Wdeprecated-declarations]
 num = minor(stbuf.st_rdev);
 ^~~
In file included from /usr/include/features.h:397:0,
                from /usr/include/inttypes.h:25,
                from /home/jsmith/Build/BUILD/asterisk-14.0.1/include/asterisk/compat.h:31,
                from /home/jsmith/Build/BUILD/asterisk-14.0.1/include/asterisk.h:27,
                from chan_dahdi.c:55:
/usr/include/sys/sysmacros.h:88:1: note: declared here
__SYSMACROS_DEFINE_MINOR (__SYSMACROS_FST_IMPL_TEMPL)
^
{noformat}
Comments:By: Friendly Automation (friendly-automation) 2016-10-28 15:26:01.598-0500

Change 4222 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4222|https://gerrit.asterisk.org/4222]
By: Friendly Automation (friendly-automation) 2016-10-28 15:26:35.560-0500

Change 4223 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4223|https://gerrit.asterisk.org/4223]
By: Friendly Automation (friendly-automation) 2016-10-28 15:26:47.443-0500

Change 4224 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4224|https://gerrit.asterisk.org/4224]
By: Friendly Automation (friendly-automation) 2016-10-28 15:27:52.435-0500

Change 4222 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4222|https://gerrit.asterisk.org/4222]
By: Friendly Automation (friendly-automation) 2016-10-28 15:28:08.561-0500

Change 4223 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4223|https://gerrit.asterisk.org/4223]
By: Friendly Automation (friendly-automation) 2016-10-28 15:28:18.818-0500

Change 4224 had a related patch set uploaded by Kevin Harwell:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4224|https://gerrit.asterisk.org/4224]
By: Kevin Harwell (kharwell) 2016-10-31 14:25:48.100-0500

Built Asterisk on Fedora 24 and Ubuntu 16.04 using gcc 6.2 and never saw the particular warning mentioned in this issue. However I did see deprecation warnings (mentioned in ASTERISK-26509) with regards to the 'readdir_r' function after upgrading to glibc 2.24. Other than that things seem to build fine on gcc 6.2.
By: Friendly Automation (friendly-automation) 2016-11-08 04:58:07.055-0600

Change 4223 merged by Joshua Colp:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4223|https://gerrit.asterisk.org/4223]
By: Friendly Automation (friendly-automation) 2016-11-08 04:58:13.610-0600

Change 4224 merged by Joshua Colp:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4224|https://gerrit.asterisk.org/4224]
By: Friendly Automation (friendly-automation) 2016-11-08 04:58:21.717-0600

Change 4222 merged by Joshua Colp:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4222|https://gerrit.asterisk.org/4222]
By: Friendly Automation (friendly-automation) 2017-01-27 16:50:43.176-0600

Change 4839 merged by George Joseph:
stasis_recording/stored: remove calls to deprecated readdir_r function.

[https://gerrit.asterisk.org/4839|https://gerrit.asterisk.org/4839]