| Summary: | ASTERISK-18412: iLBC issues during install | ||||
| Reporter: | Jeremy Kister (jkister) | Labels: | |||
| Date Opened: | 2011-09-02 19:30:32 | Date Closed: | 2011-09-19 11:06:07 | ||
| Priority: | Critical | Regression? | |||
| Status: | Closed/Complete | Components: | Codecs/codec_ilbc | ||
| Versions: | 1.8.6.0 | Frequency of Occurrence | Constant | ||
| Related Issues: |
| ||||
| Environment: | Attachments: | ( 0) get_ilbc_source.patch ( 1) get_ilbc.patch | |||
| Description: | contrib/scripts/get_ilbc_source.sh is now broken since www.ilbcfreeware.org is offline and decommissioned. asterisk installs that want codec_ilbc now fail in a non-intuitive way. | ||||
| Comments: | By: Jeremy Kister (jkister) 2011-09-02 21:58:44.817-0500 We need a copyright/license person to review iLBC. From what I can gather, we can use, modify, redistribute, or <INSERT ANY VERB HERE> the code free of charge under any circumstances. the actual code we're using is parsed from the IETF RFC, at: http://www.ietf.org/rfc/rfc3951.txt. some reference to iLBC copyright is at: http://www.webrtc.org/license-rights The reason I have confusion about the rights is because of the ambiguity between the place we are getting the code (the RFC) and the webRTC, whom is claiming ownership but is never mentioned in the RFC nor code itself. *but* in either case, the webRTC/Google basically tell us we can do anything we want with the code. Since we're not distributing it (only providing a script to get the code), we're bound even less. For now i'll play it safe by inserting a blurb saying 'you must agree to the license', but when the end user reads the license it'll basically tell them they're free to do anything they want with it. By: Jeremy Kister (jkister) 2011-09-02 23:41:21.709-0500 {code} tar zxf asterisk-1.8.6.0.tar.gz patch -p1 -d asterisk-1.8.6.0/ < get_ilbc_source.patch cd asterisk-1.8.6.0 chmod ugo+x contrib/scripts/get_ilbc_source.pl contrib/scripts/get_ilbc_source.pl ./configure make menuselect # codecs section, turn on codec_ilbc make make install {code} By: Jeremy Kister (jkister) 2011-09-02 23:57:53.963-0500 Related: ASTERISK-17971 (this is why i chose to write the implementation in Perl; we dont rely on awk portability) By: Vladimir Mikhelson (vmikhelson) 2011-09-05 21:49:32.458-0500 Jeremy, Thank you for the patch. My test did not find any issues. All 48 files appeared to be different in size compared to the original download. This looks like it is introduced by the inconsistent use of tabs and spaces in the source and header files. -Vladimir By: Gregory Hinton Nietsky (irroot) 2011-09-07 01:03:28.913-0500 This issue is marked as blocker here is a fix to rectify the change on the source site and maintain the consistancy for 1.8 for 10 perhaps relook at licence requirement or the perl option By: Jeremy Kister (jkister) 2011-09-07 01:13:33.508-0500 interesting - it seems ilbcfreeware.org is back alive. i highly recommend removing that -q parameter to wget - it's what caused the error to be cryptic instead of understandable. By: Leif Madsen (lmadsen) 2011-09-19 11:06:07.096-0500 Committed to the 1.8 branch and will be merged into 1.8.7.0-rc2. | ||||