[Home]

Summary:ASTERISK-15872: [patch] Segmentation fault when using two codec modules that register the same src and dst format
Reporter:Moises Silva (moy)Labels:
Date Opened:2010-03-24 10:31:48Date Closed:2010-07-16 10:21:46
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Codecs/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) translate.rev254273.patch
Description:When some component registers a translator with the same src/dst format as an existing translator but with higher priority ( lower cost ) Asterisk dies with segmentation fault due to null pointer dereference.

****** STEPS TO REPRODUCE ******

Load 2 codec modules ( like g729 for example ) loading the one with higher cost first. In my case is mod_dahdi_codec vs another g729 proprietary codec with lower cost.
Comments:By: Moises Silva (moy) 2010-03-24 10:33:10

I meant codec_dahdi.so

Patch attached.

By: Moises Silva (moy) 2010-03-31 11:28:06

Anything else you need from me? I tested the change myself with success and seems pretty straight forward.

By: Digium Subversion (svnbot) 2010-07-16 10:20:39

Repository: asterisk
Revision: 277143

U   trunk/main/translate.c

------------------------------------------------------------------------
r277143 | seanbright | 2010-07-16 10:20:39 -0500 (Fri, 16 Jul 2010) | 8 lines

Avoid crashing when installing a duplicate translation path with a lower cost.

(closes issue ASTERISK-15872)
Reported by: moy
Patches:
     translate.rev254273.patch uploaded by moy (license 222)
Tested by: moy

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277143

By: Digium Subversion (svnbot) 2010-07-16 10:21:45

Repository: asterisk
Revision: 277144

_U  branches/1.6.2/
U   branches/1.6.2/main/translate.c

------------------------------------------------------------------------
r277144 | seanbright | 2010-07-16 10:21:45 -0500 (Fri, 16 Jul 2010) | 15 lines

Merged revisions 277143 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r277143 | seanbright | 2010-07-16 11:20:40 -0400 (Fri, 16 Jul 2010) | 8 lines
 
 Avoid crashing when installing a duplicate translation path with a lower cost.
 
 (closes issue ASTERISK-15872)
 Reported by: moy
 Patches:
       translate.rev254273.patch uploaded by moy (license 222)
 Tested by: moy
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277144