| Summary: | ASTERISK-11677: Deadlock in chan_sip | ||
| Reporter: | callguy (callguy) | Labels: | |
| Date Opened: | 2008-03-18 13:36:25 | Date Closed: | 2008-04-08 10:46:01 |
| Priority: | Blocker | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) 20080319__bug12252.diff.txt ( 1) csl-03182008-r104119.txt | |
| Description: | We just had a deadlock in chan_sip, core show locks is attahced. I also have the output from ast_grab_core if that is of use to anyone let me know and I'll upload or provide access to the machine. | ||
| Comments: | By: Tilghman Lesher (tilghman) 2008-03-19 10:49:41 After discussing this with file on IRC, we came up with the concept expressed in this patch. Please test it out. By: callguy (callguy) 2008-03-19 17:07:32 Corydon76: Thanks for your help. I'm patching a couple of servers and will test this out, however, it's going to be a little bit tricky to call it a positive test - I've only seen this issue happen that one time. Will let you know if we see any problems or recurrence. By: callguy (callguy) 2008-04-07 23:12:23 Corydon76: We've been testing this for a while and haven't seen any recurrence of the deadlock or any adverse affects. I think you can close this one out. By: Digium Subversion (svnbot) 2008-04-08 10:34:39 Repository: asterisk Revision: 113348 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r113348 | tilghman | 2008-04-08 10:34:30 -0500 (Tue, 08 Apr 2008) | 7 lines Move check for still-bridged channels out a little further, to avoid possible deadlocks. (Closes issue ASTERISK-11677) Reported by: callguy Patches: 20080319__bug12252.diff.txt uploaded by Corydon76 (license 14) Tested by: callguy ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113348 By: Digium Subversion (svnbot) 2008-04-08 10:44:12 Repository: asterisk Revision: 113349 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r113349 | tilghman | 2008-04-08 10:44:09 -0500 (Tue, 08 Apr 2008) | 15 lines Merged revisions 113348 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r113348 | tilghman | 2008-04-08 10:39:16 -0500 (Tue, 08 Apr 2008) | 7 lines Move check for still-bridged channels out a little further, to avoid possible deadlocks. (Closes issue ASTERISK-11677) Reported by: callguy Patches: 20080319__bug12252.diff.txt uploaded by Corydon76 (license 14) Tested by: callguy ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113349 By: Digium Subversion (svnbot) 2008-04-08 10:46:01 Repository: asterisk Revision: 113350 _U branches/1.6.0/ U branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r113350 | tilghman | 2008-04-08 10:46:00 -0500 (Tue, 08 Apr 2008) | 23 lines Merged revisions 113349 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r113349 | tilghman | 2008-04-08 10:48:58 -0500 (Tue, 08 Apr 2008) | 15 lines Merged revisions 113348 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r113348 | tilghman | 2008-04-08 10:39:16 -0500 (Tue, 08 Apr 2008) | 7 lines Move check for still-bridged channels out a little further, to avoid possible deadlocks. (Closes issue ASTERISK-11677) Reported by: callguy Patches: 20080319__bug12252.diff.txt uploaded by Corydon76 (license 14) Tested by: callguy ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=113350 | ||