Index: channels/chan_sip.c =================================================================== --- channels/chan_sip.c (revision 108133) +++ channels/chan_sip.c (working copy) @@ -1272,7 +1272,7 @@ static void sip_scheddestroy(struct sip_pvt *p, int ms); static int sip_cancel_destroy(struct sip_pvt *p); static void sip_destroy(struct sip_pvt *p); -static void __sip_destroy(struct sip_pvt *p, int lockowner); +static int __sip_destroy(struct sip_pvt *p, int lockowner); static void __sip_ack(struct sip_pvt *p, int seqno, int resp, int sipmethod); static void __sip_pretend_ack(struct sip_pvt *p); static int __sip_semi_ack(struct sip_pvt *p, int seqno, int resp, int sipmethod); @@ -3051,11 +3051,22 @@ } /*! \brief Execute destruction of SIP dialog structure, release memory */ -static void __sip_destroy(struct sip_pvt *p, int lockowner) +static int __sip_destroy(struct sip_pvt *p, int lockowner) { struct sip_pvt *cur, *prev = NULL; struct sip_pkt *cp; + /* We absolutely cannot destroy the rtp struct while a bridge is active or we WILL crash */ + if (p->rtp && ast_rtp_get_bridged(p->rtp)) { + ast_verbose("Bridge still active. Delaying destroy of SIP dialog '%s' Method: %s\n", p->callid, sip_methods[p->method].text); + return -1; + } + + if (p->vrtp && ast_rtp_get_bridged(p->vrtp)) { + ast_verbose("Bridge still active. Delaying destroy of SIP dialog '%s' Method: %s\n", p->callid, sip_methods[p->method].text); + return -1; + } + if (sip_debug_test_pvt(p) || option_debug > 2) ast_verbose("Really destroying SIP dialog '%s' Method: %s\n", p->callid, sip_methods[p->method].text); @@ -3096,15 +3107,10 @@ AST_SCHED_DEL(sched, p->waitid); AST_SCHED_DEL(sched, p->autokillid); - /* We absolutely cannot destroy the rtp struct while a bridge is active or we WILL crash */ if (p->rtp) { - while (ast_rtp_get_bridged(p->rtp)) - usleep(1); ast_rtp_destroy(p->rtp); } if (p->vrtp) { - while (ast_rtp_get_bridged(p->vrtp)) - usleep(1); ast_rtp_destroy(p->vrtp); } if (p->udptl) @@ -3140,7 +3146,7 @@ } if (!cur) { ast_log(LOG_WARNING, "Trying to destroy \"%s\", not found in dialog list?!?! \n", p->callid); - return; + return 0; } /* remove all current packets in this dialog */ @@ -3158,6 +3164,7 @@ ast_string_field_free_memory(p); free(p); + return 0; } /*! \brief update_call_counter: Handle call_limit for SIP users @@ -15576,9 +15583,9 @@ sipsock_read_id = NULL; } } +restartsearch: /* Check for interfaces needing to be killed */ ast_mutex_lock(&iflock); -restartsearch: t = time(NULL); /* don't scan the interface list if it hasn't been a reasonable period of time since the last time we did it (when MWI is being sent, we can @@ -15649,6 +15656,8 @@ !sip->owner) { ast_mutex_unlock(&sip->lock); __sip_destroy(sip, 1); + ast_mutex_unlock(&iflock); + usleep(1); goto restartsearch; } ast_mutex_unlock(&sip->lock); @@ -18087,13 +18096,20 @@ monitor_thread = AST_PTHREADT_STOP; ast_mutex_unlock(&monlock); +restartdestroy: ast_mutex_lock(&iflock); /* Destroy all the interfaces and free their memory */ p = iflist; while (p) { pl = p; p = p->next; - __sip_destroy(pl, TRUE); + if (__sip_destroy(pl, TRUE) < 0) { + /* Something is still bridged, let it react to getting a hangup */ + iflist = p; + ast_mutex_unlock(&iflock); + usleep(1); + goto restartdestroy; + } } iflist = NULL; ast_mutex_unlock(&iflock);