[Home]

Summary:ASTERISK-11135: [patch] Proper Hebrew support for Asterisk
Reporter:Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech)Labels:
Date Opened:2008-01-01 11:23:46.000-0600Date Closed:2008-06-18 18:33:44
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail-29012008.c.patch
( 1) app_zapscan-28012008.c.patch
( 2) asterisk-sounds-il.zip
( 3) hebrew-digits.tar.gz
( 4) hebrew-digits.txt
( 5) Hebrew-Sounds.html
( 6) Hebrew-Sounds.ods
( 7) say_he_wip1.diff
( 8) say.c.patch-12042008
Description:The current Hebrew support in Asterisk is fairly incomplete, both in terms of recordings and in term of proper Hebrew grammar. The following will serve as a patch upload point for myself and Ido Kanner, to upload a patch for proper Hebrew support.

****** ADDITIONAL INFORMATION ******

01.01.2008
Added the first hebrew patch for app_voicemail.c (fully tested and working).
Comments:By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-01 11:31:18.000-0600

01.01.2008
Patch for say.c will be available later on today or within 48 hours.
By: Tzafrir Cohen (tzafrir) 2008-01-01 13:25:59.000-0600

Hi, great to see progress on this one!

Please just fill the license bit so it can be officially submitted.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-03 12:11:32.000-0600

Ok, it's taking a bit more time to debug, we hope to finish by early next week :-(
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-04 15:49:50.000-0600

uploaded a patch for say.c - thanks to Ido Kaneer who had worked on the date formats and time formats. Numeric playbacks were done by Nir Simionovich.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-04 15:57:18.000-0600

Recordings will be available at http://www.asterisk.org.il, once the proper open license for the recordings is attached to those.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-07 09:54:59.000-0600

anybody handling the acceptance of this patch?
By: Michiel van Baak (mvanbaak) 2008-01-07 10:55:38.000-0600

Can you provide the recordings as well?
I tried to find them on the website you noted, but that's pretty hard to read ;)
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-07 13:47:45.000-0600

I've uploaded the first set of sounds in here - there are some other sound files that are missing, but these mostly relate to the patched files at this point - so the rest will be available later on.
By: mbrevda (lazytt) 2008-01-08 05:44:42.000-0600

hmm, seems that the digits are garbled, but the rest sounds great! Can wait to see this patch in 1.4
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-08 05:51:23.000-0600

I'll check later tonight the numbers and upload a new batch if required.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-08 05:56:10.000-0600

did you also check the general language of the hebrew voicemail settings?
By: mbrevda (lazytt) 2008-01-08 06:20:18.000-0600

I ran the following as a test:
exten => 999888,1,SayDigits(1234567890)
with language set to he. The digits wouldn't play. Please note: I did NOT apply the patch

p.s. are you on irc?
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-08 06:37:08.000-0600

when i'm on IRC I'm under the nick NirS - I'll be there later on tonight (israel time).
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-09 02:15:06.000-0600

The new digit recordings had been uploaded as hebrew-digits.tar.gz - with the LICENSE file for the recordings.
By: mbrevda (lazytt) 2008-01-10 10:05:57.000-0600

it might be my imagination, but perhaps you uploaded the English digits by mistake?
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-10 10:13:17.000-0600

no I didn't, the file called hebrew-digits.tar.gz contains all the digits and numbers for the hebrew patches.
By: Yehavi Bourvine (yehavi) 2008-01-13 09:41:53.000-0600

First - thanks for all the work and the recordings!
Next, why is this modification:

@@ -5828,8 +5924,14 @@
               if (vms->starting) {
                       if (vms->lastmsg > -1) {
                               res = ast_play_and_wait(chan, "vm-onefor");
-                               if (!res)
-                                       res = vm_play_folder_name(chan, vms->vmbox);
+                               if (!res) {
+                                       if (!strcasecmp(chan->language, "he")) {
+                                           res = ast_play_and_wait(chan, "vm-for");
+                                           res = ast_play_and_wait(chan, "vm-INBOX");
+                                       } else {
+                                           res = vm_play_folder_name(chan, vms->vmbox);
+                                       }
+                               }

It causes the code to say "Press 1 for new messages" always, while the old code said NEW or OLD depending whether there were new or old messages, and it was the correct code...

                      Thanks, __Yehavi:
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-13 10:06:12.000-0600

Hmmm... I'll look into it tonight and see why I did that, probably a typo I did or something.
By: Yehavi Bourvine (yehavi) 2008-01-13 10:25:21.000-0600

I wrote a loop to announce:
 SayDigits(${i});  SayNumber(${i},f); SayNumber(${i},m);

and here are some notes:
- In order for SayDigits to work the files f-01.gsm to f-09.gsm has to be
 replicated as 1.gsm to 9.gsm
- 20.gsm should be copied to f-20.gsm and m-20.gsm.
- 110 (and 210 and so on) is said as "hundred hundred ten".

This is for today...

                     Thanks, __Yehavi:
By: Tzafrir Cohen (tzafrir) 2008-01-13 10:34:13.000-0600

Shouldn't we have a sound file called, say, "1", for the sake of compatibility to other languages?
By: Yehavi Bourvine (yehavi) 2008-01-13 10:37:47.000-0600

We need "1" for compatibility and "no gender" announcements, and we need the mail and female counterparts of it.

                    Thanks, __Yehavi:
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-13 11:26:09.000-0600

Hi guys,

As you may remeber, there is no such thing as a neutral number (genderless) in hebrew - as none politically correct as it may sound.

I think that in general, creating symbolic links from 1 to 1-f should be enough, I don't see a reason to replicate the entire recording structure again.

In regards to the bugs, I'll take a look at this and fix - thanks for the heads up.

Nir
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-13 11:52:08.000-0600

New patch for say.c uploaded, to handle the issue Yehavi had reported. Bug was in the handling of numbers smaller than 11 - I forgot to put 10 into the case
:-)

In regards to genderless numbers, the function will default to male in a case where the gender was not defined in the command line.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-13 12:24:58.000-0600

New patch for voicemail uploade, although I have to admit that a portion of the new patch is a shameless hack. In hebrew, while male and female numbers are announced differently, there are also different number announcements when you count things, such as "two new messages". The ast_say_number function currently doesn't support that kind of number readout, so the voicemail will read out a static file for the case of 2 messages in either the new voicemail or old voicemail boxes - again, this is a shameless hack and I admit it.

The previos bug that was reported is now fixed.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-17 13:43:07.000-0600

Minor update - fix the way dates are being read, so it would be in the proper male/female mixture. In addition, fix a bug where the number 20 was never read out.
By: Yehavi Bourvine (yehavi) 2008-01-20 07:31:27.000-0600

The at.gsm should have a Hebrew recording as well ("besha'a").

                       Thanks, __Yehavi:
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-20 07:53:09.000-0600

Good idea, I'll handle this.
By: Tzafrir Cohen (tzafrir) 2008-01-20 07:56:01.000-0600

"beshaa" or maybe just "be"? The latter is less of a surprise.
By: Yehavi Bourvine (yehavi) 2008-01-23 06:38:19.000-0600

More recordings needed:
- Yesterday
- Days of the week
- Days of the month (I don't have so old messages, but if no weekdays
 are recorded then I assume the month names are not as well).

                     Thanks! __Yehavi:
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-25 12:26:39.000-0600

Hi all,

The sounds are now available at the asterisk.org.il website, following the below link:

http://www.asterisk.org.il/downloads/asterisk-hebrew-1.0.0-beta.tar.gz

Recordings had been released under the CREATIVE COMMONS license, utilizing Creative Commons Attribution-No Derivative Works 3.0 Unported License.

Please download and test with the latest patches on this page. Bug reports should be sent to nirs@greenfieldtech.net or reported on this page.

Regards,
 Nir
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-27 19:41:53.000-0600

Add new updated patches to app_voicemail and fixed app_zapscan.

app_voicemail - added the ability to say "no new messages" in a single message and making sure that browsing the folders doesn't break the message count read out.

app_zapscan - make sure that hebrew channel numbers are read out in female, not male - hebrew is funky that way.
By: Olle Johansson (oej) 2008-01-28 01:31:16.000-0600

There are formatting errors in this source - like comments starting with "//". Please check the coding guidelines - thanks.
By: Olle Johansson (oej) 2008-01-28 01:37:40.000-0600

Please delete sections that are commented out, like:
+/*
+ if (!res)
+ res = ast_streamfile(chan, "digits/oh", lang);
+*/
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-28 04:43:47.000-0600

new patches uploaded
By: Jason Parker (jparker) 2008-01-29 14:14:51.000-0600

There are still many significant coding guidelines violations in these patches.  Use tabs rather than spaces where appropriate, no // style comments, no nested if blocks without braces.

I also have several language concerns (not being a Hebrew speaker).  Near the beginning of the voicemail patch, you change how it says "first message", and it appears to have the potential to say "message first message".  Near the end of the voicemail patch, you remove the saying of the folder name.  You have several TODO comments sprinkled throughout about saying "Shtei", and I'm unsure why that is.

You should not be using "digits/he/at", you should be using "digits/at" like all the others.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-29 14:26:50.000-0600

I'll look into this remarks tomorrow night - no problem.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-31 06:13:05.000-0600

qwell - "I also have several language concerns (not being a Hebrew speaker). Near the beginning of the voicemail patch, you change how it says "first message", and it appears to have the potential to say "message first message"

Nir - Well, hebrew is funny that way. In hebrew, we are required to say: "message first" and "message last" for the first and last messages, while we say: "message number X" when dealing with the rest of the messages. I'm aware that this structure is mostly common with Shemich languages (hebrew, arabic, pharsi I believe too), but it will a common denominator to this area of the world. I've hired an Arabic tutor to assist me in migrating Asterisk applications to Arabic too, but I'll start working on that only after I'm done with hebrew.

qwell - "Near the end of the voicemail patch, you remove the saying of the folder name."

Nir - Please refer me to a specific location, so I can look into it.

qwell - "You have several TODO comments sprinkled throughout about saying "Shtei", and I'm unsure why that is."

Nir - In hebrew we have different words for saying: "two boys" and "two girls". This form is called "Smichut" in hebrew. Asterisk as a PBX doesn't support this special linguistic structure. The word "Shtei" refers to "two girls", actually saying "two messages", as a "message" in hebrew is of female gender.

Funny thing that happend during the debugging was a case when the hebrew announcer and Alisson's voice were co-played during a single sentence. The announcer said that he'd love to meet Allison, but that wasn't the way to do it :-)
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-02-03 08:42:51.000-0600

Ok, I believe I've fixed all the syntax issues and the logical language issues.
I've also cleaned up some parts of the code that were really ugly (have no idea what I was thinking). The uploaded file is a comulative patch for all the modified files.

qwell, I think I've found the logical error that you pointed out. I was unable to create such a situation, however, I've managed to see what you meant and I believe I've fixed it.

Lets see if this one passes the syntax check, so it can go into the next release or something.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-02-05 17:26:24.000-0600

guys, any progress on this one? is it ok syntax wise?
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-02-14 13:43:31.000-0600

guys? any progress on this one? what's going on? ...
By: Tilghman Lesher (tilghman) 2008-02-26 18:59:06.000-0600

This last patch appears to be a mix of code changes and whitespace changes.  I'd like to see JUST the code changes, separated out into its own patch.

Whitespace changes are fine, but they should be separated into their own patch file, apart from code changes.


By: Tilghman Lesher (tilghman) 2008-02-26 19:10:01.000-0600

Additionally, I disagree with most of your whitespace changes.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-02-27 01:17:08.000-0600

Well, let me see what I can do, it's been a while since I modified the code - and I hadn't saved the code changes without the white spaces, so lets see what I can do with this.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-03-09 17:06:40

corydon,

When are you available on the IRC? I'd like to go over the patch with you, and see how we can finish this, quite alot of people over here are waiting for this patch.

Please send me an email to nirs@greenfieldtech.net
By: Tzafrir Cohen (tzafrir) 2008-03-10 17:42:20

Why is the zapscan patch needed?  Shouldn't the female form be the default one?
By: Tilghman Lesher (tilghman) 2008-03-10 18:14:15

greenfieldtech:  until you go through and remove the whitespace changes, there is nothing more to discuss.  Please see the CODING-GUIDELINES document on the patch specification, specifically the part that says that whitespace patches should be separate from code patches.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-03-10 22:42:36

Hi Corydon,

 Tzafrir and I will work on this and correct the issues

Nir
By: Tzafrir Cohen (tzafrir) 2008-03-12 19:06:57

Reduced patch to a reviewable size. It now aplies vs. trunk r107231.  As the name suggests this is still not a proper patch. But I believe that you can now get a better idea of the exact changes.
By: Tilghman Lesher (tilghman) 2008-03-13 08:27:48

Okay, let me know when it's ready to be considered.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-03-24 16:20:49

tzafrir, would you like to schedule some time together - so we can finish this?
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-04-09 15:46:03

looks like I need to re-write some portions of this patch, I'll start working on it :-(
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-04-10 05:52:43

Ok, I've uploaded a new patch to say.c
This patch is basically the same patch from before, only modification regarding better famale/male handling in hebrew syntax defaults.
I will now upload one patch at a time, awaiting confirmation for each patch, instead of uploading all the patches at the same time.
Corydon, I would highly appreciate it if you can go over this and see if it's ok and get it in. People had been waiting for this over here for about 4 months now.
By: Tzafrir Cohen (tzafrir) 2008-04-10 06:38:53

It doesn't work this way. Please avoid making unnecessary indentation changes and such. It's really not clear what you actually change.

Another comment: you seem to use a non-standard convention for Hebrew number file names. What should I get for:

 Set(LANGUAGE=he)
 Playback(1)

This works for all other languages. But for Hebrew, I'll get the default English file (or nothing).
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-04-10 06:42:16

That's funny, I used Set(LANGUAGE()=he) which worked just fine for me.
Tzafrir, please send me your phone number by email, looks like I'm doing something wrong here.
By: Tilghman Lesher (tilghman) 2008-04-10 06:47:39

greenfieldtech:  Again, as Tzafrir said, you are making indentation changes, which are not only bad, because they make the code changes difficult to see, but also bad, because they are not in compliance with Asterisk coding guidelines.
By: Tilghman Lesher (tilghman) 2008-04-10 06:50:28

greenfieldtech:  At this point, I think I am justifiably not confident in your ability to follow the guidelines.  If your next patch is not reasonably within those guidelines, ESPECIALLY as it pertains to formatting, I have to take that as a sign that you do not intend to comply with those guidelines, and this issue will be closed.


By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-04-11 19:52:50

Ok,

After spending some time on the IRC with corydon, I'm uploading a new patch, which is supposed to be in accordance to the formating syntax. Many of the remarks were removed, and some other clean ups and a small optimization.

Hope this one makes the cut.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-04-24 18:55:52

Guys, can someone take a look at the above, I've spent a great deal of time on correcting the various whitespace/tab/format issues with Corydon, so I'd like to put this behind and continue to the next in line.
By: Yehavi Bourvine (yehavi) 2008-04-26 23:49:56

Hello,

 I've tried the patches on Asterisk-1.4.19.1:

app_voicemail-29012008.c.patch:
 -Fails mostly due to white spaces. applied it manually...
 - vm_intro_he patch is incorrect: instead of adding a new function it is
   editing vm_intro_en and then add it again.

say.c.patch-12042008:
 - You have to change it to Unix format from DOS format.
 - Change the filename to be relative.
 - Applied cleanly.

                     Thanks! __Yehavi:
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-04-27 01:14:19

Hi Yehavi,

 I'm currently concentrating on finishing the say.c patch, so I hadn't yet touched the voicemail patch.
I'm still waiting for Digium team to examine the latest say.c patch, so they will include these into the
main TRUNK.

Nir
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-05-21 07:28:52

Can someone please take a look into say.c.patch-12042008 and see if it is ready to be merged? this has been waiting in here for over a month now - please take a look at it so I can start working on the other patches.
I want to make sure that they way I'm working now is correct.
By: Tilghman Lesher (tilghman) 2008-05-21 08:00:54

Yes; it's ready to be merged.  I will need the doc/lang/hebrew-digits.txt file to merge at the same time, however.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-05-21 14:57:18

Hi Corydon, hebrew digits file listing uploaded, please make your remarks if any.
By: Tilghman Lesher (tilghman) 2008-05-21 15:31:15

1) I need the .gsm suffix removed.  Remember, the recordings could be done in any of a number of formats, not just GSM.

2) I'd prefer the scripts to be adjusted to the actual script of what is to be said, in the actual language.  I realize that Hebrew has a different alphabet, but I'd really like to see something along those lines.  The trouble with putting the script in English is all the pesky "a", "an", "the", and other small words that sometimes invade recordings that make the results not quite sound right.  And how you translate the words may not be exactly how another will translate the words, so I'd like the script to be as precise as possible.

3) The name of the file should really be "doc/lang/he.txt", and another column should be added with the name of the module which requires each sound, i.e. "core", "voicemail", "meetme", etc.

4) Finally, if there are regional differences to Hebrew (there are in other languages; I'm not familiar with Hebrew, so I don't know for sure), note what region you're from, so that any inflections by a future voice artist can be made properly (and other similar adjustments).

What I'm trying to do is make this file the gold standard for all such voice description files, so later contributors can follow the same format.
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-05-23 02:39:55

Hmmm... How about creating a file that contains the information about each recording in hebrew, which means the actual translated text. I have that file in Excel format, that the translator did. I can export it to a CSV format, and people in Israel load this file into an Hebrew compatible viewer.

What do you think? I don't believe that starting to write in English Hebrew sentences will do good for anybody in Israel, and the same applies for Arabic.
By: Tilghman Lesher (tilghman) 2008-05-23 07:04:36

If you want to make the file Unicode text or perhaps even HTML, that would be fine.  I just want to have a file that contains exact script for the indicated language, but let the file be an editable format (i.e. not PDF).  I suppose Excel format would be fine, but in the case of a spreadsheet, I'd prefer an open format like ODF (.ods).
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-05-23 08:28:32

Hmmm... Sounds great, I'll start working on it
By: Tilghman Lesher (tilghman) 2008-06-08 21:35:09

greenfieldtech:  any progress here?
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-06-10 12:09:46

Hi Corydon,

Sorry for the delay on this, still compiling all the texts into a proper
Open Office spreadsheet.

Nir
By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-06-15 16:33:38

Hi Cory,

 I've finally got to ordering all the recordings into 2 files. One is an Open Office spreadsheet, the other is an HTML output of the same file, readable in Hebrew enabled browsers.

 I hope this is OK in order to proceed.

Nir
By: Digium Subversion (svnbot) 2008-06-18 17:01:39

Repository: asterisk
Revision: 123769

A   branches/1.4/doc/lang/
A   branches/1.4/doc/lang/hebrew.ods
U   branches/1.4/main/say.c

------------------------------------------------------------------------
r123769 | tilghman | 2008-06-18 17:01:38 -0500 (Wed, 18 Jun 2008) | 8 lines

Add support for saying numbers in Hebrew.
(closes issue ASTERISK-11135)
Reported by: greenfieldtech
Patches:
      say.c.patch-12042008 uploaded by greenfieldtech (license 369)
      Hebrew-Sounds.ods uploaded by greenfieldtech
      (with signficant changes to the spreadsheet by me)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123769
By: Digium Subversion (svnbot) 2008-06-18 17:10:19

Repository: asterisk
Revision: 123770

_U  trunk/
A   trunk/doc/lang/
D   trunk/doc/lang/hebrew.ods
A   trunk/doc/lang/hebrew.ods
U   trunk/main/say.c

------------------------------------------------------------------------
r123770 | tilghman | 2008-06-18 17:10:18 -0500 (Wed, 18 Jun 2008) | 16 lines

Merged revisions 123769 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123769 | tilghman | 2008-06-18 17:08:30 -0500 (Wed, 18 Jun 2008) | 8 lines

Add support for saying numbers in Hebrew.
(closes issue ASTERISK-11135)
Reported by: greenfieldtech
Patches:
      say.c.patch-12042008 uploaded by greenfieldtech (license 369)
      Hebrew-Sounds.ods uploaded by greenfieldtech
      (with signficant changes to the spreadsheet by me)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123770
By: Digium Subversion (svnbot) 2008-06-18 17:11:21

Repository: asterisk
Revision: 123772

_U  branches/1.6.0/
A   branches/1.6.0/doc/lang/
D   branches/1.6.0/doc/lang/hebrew.ods
A   branches/1.6.0/doc/lang/hebrew.ods
U   branches/1.6.0/main/say.c

------------------------------------------------------------------------
r123772 | tilghman | 2008-06-18 17:11:21 -0500 (Wed, 18 Jun 2008) | 24 lines

Merged revisions 123770 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r123770 | tilghman | 2008-06-18 17:17:17 -0500 (Wed, 18 Jun 2008) | 16 lines

Merged revisions 123769 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123769 | tilghman | 2008-06-18 17:08:30 -0500 (Wed, 18 Jun 2008) | 8 lines

Add support for saying numbers in Hebrew.
(closes issue ASTERISK-11135)
Reported by: greenfieldtech
Patches:
      say.c.patch-12042008 uploaded by greenfieldtech (license 369)
      Hebrew-Sounds.ods uploaded by greenfieldtech
      (with signficant changes to the spreadsheet by me)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123772
By: Digium Subversion (svnbot) 2008-06-18 18:33:44

Repository: asterisk
Revision: 123824

_U  team/seanbright/resolve-shadow-warnings/
A   team/seanbright/resolve-shadow-warnings/doc/lang/
D   team/seanbright/resolve-shadow-warnings/doc/lang/hebrew.ods
A   team/seanbright/resolve-shadow-warnings/doc/lang/hebrew.ods
U   team/seanbright/resolve-shadow-warnings/main/say.c

------------------------------------------------------------------------
r123824 | seanbright | 2008-06-18 18:33:41 -0500 (Wed, 18 Jun 2008) | 24 lines

Merged revisions 123770 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r123770 | tilghman | 2008-06-18 18:17:17 -0400 (Wed, 18 Jun 2008) | 16 lines

Merged revisions 123769 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r123769 | tilghman | 2008-06-18 17:08:30 -0500 (Wed, 18 Jun 2008) | 8 lines

Add support for saying numbers in Hebrew.
(closes issue ASTERISK-11135)
Reported by: greenfieldtech
Patches:
      say.c.patch-12042008 uploaded by greenfieldtech (license 369)
      Hebrew-Sounds.ods uploaded by greenfieldtech
      (with signficant changes to the spreadsheet by me)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=123824