[Home]

Summary:ASTERISK-09837: Service level might exceed 100%
Reporter:Makoto Dei (makoto)Labels:
Date Opened:2007-07-08 20:22:41Date Closed:2007-07-10 14:45:26
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-1.4.6-queue-servicelevel.patch
( 1) queuesl.diff
Description:When a call to queue is hung up during the hold time announce,
service level exceeds 100%, because callscompletedinsl of that
queue is incremented but callscompleted is not.

See attached patch.


****** STEPS TO REPRODUCE ******

1. Reload asterisk to clear queue status
2. Call to queue
3. Pick up within SL
4. Hang up the call
5. Call to queue
6. Hang up during the hold time announce
7. exec "show queues" command

"show queues" command says that SL is 200%
Comments:By: Jason Parker (jparker) 2007-07-09 11:33:30

It doesn't really make sense to me that recalc_holdtime would return the current time in the queue.  I'm thinking of other ways to do this.
By: Jason Parker (jparker) 2007-07-09 12:08:20

Here, try this patch.
By: Makoto Dei (makoto) 2007-07-10 03:19:17

> It doesn't really make sense to me that recalc_holdtime would return
> the current time in the queue.
I agree with you.
And your patch works fine for me.
By: Digium Subversion (svnbot) 2007-07-10 14:45:26

Repository: asterisk
Revision: 74429

------------------------------------------------------------------------
r74429 | qwell | 2007-07-10 14:45:23 -0500 (Tue, 10 Jul 2007) | 23 lines

Merged revisions 74428 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue ASTERISK-9837)
................
r74428 | qwell | 2007-07-10 14:58:53 -0500 (Tue, 10 Jul 2007) | 14 lines

Merged revisions 74427 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74427 | qwell | 2007-07-10 14:57:20 -0500 (Tue, 10 Jul 2007) | 6 lines

Fix an issue where it was possible to have a service level of over 100