| Summary: | ASTERISK-05023: [patch] OSP authentication issue | ||
| Reporter: | Di-Shi Sun (homesick) | Labels: | |
| Date Opened: | 2005-09-08 09:51:57 | Date Closed: | 2008-01-15 15:48:11.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) AuthenticationFailure_with_JD_Changes.doc ( 1) osp_auth.patch | |
| Description: | Currently, the authentication settings using allowguest=osp and ospauth cannot cover all OSP configuration scenarios. To address this deficiency, this patch proposes changes that will enable all practical call scenarios when Asterisk supports OSP. This patch does not change anything outside of the OSP auth logic. The attached word doc has more details about this issue and the patch. ****** ADDITIONAL INFORMATION ****** Disclaimer signed by TransNexus, Inc. 1/27/05 | ||
| Comments: | By: Olle Johansson (oej) 2005-09-08 10:43:17 The bitmap defines seems to be a little crazy. Have you really tried this code? You are redefining the same bits... Check the #define in the top. I guess this will have to go into the code base after 1.2 is released, since this issue was opened rather late in the process. By: Di-Shi Sun (homesick) 2005-09-08 13:33:09 You are right. The bitmap is interesting. We use the 2 bits as a value instead of as 2 separated bits. It works fine (we have fully tested the patch). What's you opinion? We can use 1 more bit, rewrite and test the patch if you think that is better. By: Olle Johansson (oej) 2005-09-08 13:41:03 Follow the rest of the code and do it the Asterisk way. If you want two separate flags, declare two separate flags. If you want one flag with several states, you might want to book a two-bit flag. By: Di-Shi Sun (homesick) 2005-09-08 16:20:29 Thanks, I get your point. I believe the patch follows the Asterisk way. Becuase in the same file (chan_sip.c), others use the same way for SIP_DTMF and SIP_NAT settings as we use for SIP_OSPAUTH. By: Kevin P. Fleming (kpfleming) 2005-09-13 22:47:29 The patch is fine, it's using the flag bits exactly the way it should be. Committe d to CVS HEAD, thanks! By: Digium Subversion (svnbot) 2008-01-15 15:48:11.000-0600 Repository: asterisk Revision: 6589 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r6589 | kpfleming | 2008-01-15 15:48:11 -0600 (Tue, 15 Jan 2008) | 2 lines support all OSP authentication models (issue ASTERISK-5023) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=6589 | ||