Index: apps/app_queue.c =================================================================== --- apps/app_queue.c (revision 100973) +++ apps/app_queue.c (working copy) @@ -99,6 +99,20 @@ #include "asterisk/astobj2.h" #include "asterisk/global_datastores.h" +/* Please read before modifying this file. + * There are three locks which are regularly used + * throughout this file, the queue list lock, the lock + * for each individual queue, and the interface list lock. + * Please be extra careful to always lock in the following order + * 1) queue list lock + * 2) individual queue lock + * 3) interface list lock + * This order has sort of "evolved" over the lifetime of this + * application, but it is now in place this way, so please adhere + * to this order! + */ + + enum { QUEUE_STRATEGY_RINGALL = 0, QUEUE_STRATEGY_ROUNDROBIN, @@ -889,15 +903,16 @@ { struct member_interface *curint; + if (interface_exists_global(interface)) + return 0; + AST_LIST_LOCK(&interfaces); AST_LIST_TRAVERSE_SAFE_BEGIN(&interfaces, curint, list) { if (!strcasecmp(curint->interface, interface)) { - if (!interface_exists_global(interface)) { - if (option_debug) - ast_log(LOG_DEBUG, "Removing %s from the list of interfaces that make up all of our queue members.\n", interface); - AST_LIST_REMOVE_CURRENT(&interfaces, list); - free(curint); - } + if (option_debug) + ast_log(LOG_DEBUG, "Removing %s from the list of interfaces that make up all of our queue members.\n", interface); + AST_LIST_REMOVE_CURRENT(&interfaces, list); + free(curint); break; } } @@ -4247,9 +4262,9 @@ continue; } - remove_from_interfaces(cur->interface); q->membercount--; ao2_unlink(q->members, cur); + remove_from_interfaces(cur->interface); ao2_ref(cur, -1); }