Index: main/asterisk.c =================================================================== --- main/asterisk.c (revision 81441) +++ main/asterisk.c (working copy) @@ -2530,7 +2530,7 @@ FILE *f; sigset_t sigs; int num; - int is_child_of_nonroot = 0; + int isroot = 1; char *buf; char *runuser = NULL, *rungroup = NULL; @@ -2543,6 +2543,9 @@ _argv[x] = argv[x]; _argv[x] = NULL; + if (geteuid() != 0) + isroot = 0; + /* if the progname is rasterisk consider it a remote console */ if (argv[0] && (strstr(argv[0], "rasterisk")) != NULL) { ast_set_flag(&ast_options, AST_OPT_FLAG_NO_FORK | AST_OPT_FLAG_REMOTE); @@ -2556,11 +2559,7 @@ ast_builtins_init(); ast_utils_init(); tdd_init(); - /* When Asterisk restarts after it has dropped the root privileges, - * it can't issue setuid(), setgid(), setgroups() or set_priority() - */ - if (getenv("ASTERISK_ALREADY_NONROOT")) - is_child_of_nonroot=1; + if (getenv("HOME")) snprintf(filename, sizeof(filename), "%s/.asterisk_history", getenv("HOME")); /* Check for options */ @@ -2695,10 +2694,10 @@ #ifndef __CYGWIN__ - if (!is_child_of_nonroot) + if (isroot) ast_set_priority(ast_opt_high_priority); - if (!is_child_of_nonroot && rungroup) { + if (isroot && rungroup) { struct group *gr; gr = getgrnam(rungroup); if (!gr) { @@ -2717,13 +2716,17 @@ ast_verbose("Running as group '%s'\n", rungroup); } - if (!is_child_of_nonroot && runuser) { + if (runuser && !ast_test_flag(&ast_options, AST_OPT_FLAG_REMOTE)) { struct passwd *pw; pw = getpwnam(runuser); if (!pw) { ast_log(LOG_WARNING, "No such user '%s'!\n", runuser); exit(1); } + if (!isroot && pw->pw_uid != geteuid()) { + ast_log(LOG_ERROR, "Asterisk started as nonroot, but runuser '%s' requested.\n", runuser); + exit(1); + } if (!rungroup) { if (setgid(pw->pw_gid)) { ast_log(LOG_WARNING, "Unable to setgid to %d!\n", (int)pw->pw_gid); @@ -2738,7 +2741,6 @@ ast_log(LOG_WARNING, "Unable to setuid to %d (%s)\n", (int)pw->pw_uid, runuser); exit(1); } - setenv("ASTERISK_ALREADY_NONROOT", "yes", 1); if (option_verbose) ast_verbose("Running as user '%s'\n", runuser); }