Index: channels/chan_sip.c =================================================================== --- channels/chan_sip.c (revision 65593) +++ channels/chan_sip.c (working copy) @@ -199,7 +199,8 @@ #define DEFAULT_RETRANS 1000 /*!< How frequently to retransmit Default: 2 * 500 ms in RFC 3261 */ #define MAX_RETRANS 6 /*!< Try only 6 times for retransmissions, a total of 7 transmissions */ -#define SIP_TRANS_TIMEOUT 32000 /*!< SIP request timeout (rfc 3261) 64*T1 +#define DEFAULT_T1 500 /*!< 500 ms for dialog setup time (RFC 3261) */ +#define SIP_TRANS_TIMEOUT 64 * DEFAULT_T1 /*!< SIP request timeout (RFC 3261) 64*T1 \todo Use known T1 for timeout (peerpoke) */ #define DEFAULT_TRANS_TIMEOUT -1 /* Use default SIP transaction timeout */ @@ -557,6 +558,7 @@ static char global_useragent[AST_MAX_EXTENSION]; /*!< Useragent for the SIP channel */ static int allow_external_domains; /*!< Accept calls to external SIP domains? */ static int global_callevents; /*!< Whether we send manager events or not */ +static int global_t1; /*!< T1 time */ static int global_t1min; /*!< T1 roundtrip time minimum */ static int global_autoframing; /*!< Turn autoframing on or off. */ static enum transfermodes global_allowtransfer; /*!< SIP Refer restriction scheme */ @@ -1118,6 +1120,7 @@ struct sip_pvt *mwipvt; /*!< Subscription for MWI */ int lastmsg; int autoframing; + int timer_t1; /*!< The maximum T1 value for the peer */ }; @@ -2058,7 +2061,7 @@ { if (ms < 0) { if (p->timer_t1 == 0) - p->timer_t1 = 500; /* Set timer T1 if not set (RFC 3261) */ + p->timer_t1 = global_t1; /* Set timer T1 if not set (RFC 3261) */ ms = p->timer_t1 * 64; } if (sip_debug_test_pvt(p)) @@ -2705,10 +2708,12 @@ dialog->callgroup = peer->callgroup; dialog->pickupgroup = peer->pickupgroup; dialog->allowtransfer = peer->allowtransfer; - /* Set timer T1 to RTT for this peer (if known by qualify=) */ - /* Minimum is settable or default to 100 ms */ + /* If there is a maxms and lastms from a qualify use that over a manual T1 + value. Otherwise, use the peer's T1 value. */ if (peer->maxms && peer->lastms) dialog->timer_t1 = peer->lastms < global_t1min ? global_t1min : peer->lastms; + else + dialog->timer_t1 = peer->timer_t1; if ((ast_test_flag(&dialog->flags[0], SIP_DTMF) == SIP_DTMF_RFC2833) || (ast_test_flag(&dialog->flags[0], SIP_DTMF) == SIP_DTMF_AUTO)) dialog->noncodeccapability |= AST_RTP_DTMF; @@ -2741,7 +2746,7 @@ if (port) *port++ = '\0'; dialog->sa.sin_family = AF_INET; - dialog->timer_t1 = 500; /* Default SIP retransmission timer T1 (RFC 3261) */ + dialog->timer_t1 = global_t1; p = find_peer(peer, NULL, 1); if (p) { @@ -4247,7 +4252,7 @@ p->prefs = default_prefs; /* Set default codecs for this call */ if (intended_method != SIP_OPTIONS) /* Peerpoke has it's own system */ - p->timer_t1 = 500; /* Default SIP retransmission timer T1 (RFC 3261) */ + p->timer_t1 = global_t1; /* Default SIP retransmission timer T1 (RFC 3261) */ if (sin) { p->sa = *sin; @@ -9223,6 +9228,8 @@ p->callingpres = peer->callingpres; if (peer->maxms && peer->lastms) p->timer_t1 = peer->lastms; + else + p->timer_t1 = peer->timer_t1; if (ast_test_flag(&peer->flags[0], SIP_INSECURE_INVITE)) { /* Pretend there is no required authentication */ ast_string_field_free(p, peersecret); @@ -10104,6 +10111,7 @@ /* - is enumerated */ ast_cli(fd, " DTMFmode : %s\n", dtmfmode2str(ast_test_flag(&peer->flags[0], SIP_DTMF))); + ast_cli(fd, " T1 : %d\n", peer->timer_t1); ast_cli(fd, " LastMsg : %d\n", peer->lastmsg); ast_cli(fd, " ToHost : %s\n", peer->tohost); ast_cli(fd, " Addr->IP : %s Port %d\n", peer->addr.sin_addr.s_addr ? ast_inet_ntoa(peer->addr.sin_addr) : "(Unspecified)", ntohs(peer->addr.sin_port)); @@ -10372,6 +10380,7 @@ ast_cli(fd, " Codec Order: "); print_codec_to_cli(fd, &default_prefs); ast_cli(fd, "\n"); + ast_cli(fd, " T1: %d\n", global_t1); ast_cli(fd, " T1 minimum: %d\n", global_t1min); ast_cli(fd, " Relax DTMF: %s\n", global_relaxdtmf ? "Yes" : "No"); ast_cli(fd, " Compact SIP headers: %s\n", compactheaders ? "Yes" : "No"); @@ -15981,6 +15990,7 @@ peer->pickupgroup = 0; peer->maxms = default_qualify; peer->prefs = default_prefs; + peer->timer_t1 = global_t1; } /*! \brief Create temporary peer (used in autocreatepeer mode) */ @@ -16205,6 +16215,11 @@ ast_log(LOG_WARNING, "'%s' is not a valid RTP keepalive time at line %d. Using default.\n", v->value, v->lineno); peer->rtpkeepalive = global_rtpkeepalive; } + } else if (!strcasecmp(v->name, "t1")) { + if ((sscanf(v->value, "%d", &peer->timer_t1) != 1) || (peer->timer_t1 < 0)) { + ast_log(LOG_WARNING, "'%s' is not a valid T1 time at line %d. Using default.\n", v->value, v->lineno); + peer->timer_t1 = global_t1; + } } else if (!strcasecmp(v->name, "setvar")) { /* Set peer channel variable */ varname = ast_strdupa(v->value); @@ -16367,6 +16382,7 @@ /* Misc settings for the channel */ global_relaxdtmf = FALSE; global_callevents = FALSE; + global_t1 = DEFAULT_T1; global_t1min = DEFAULT_T1MIN; global_matchexterniplocally = FALSE;