Index: channels/chan_zap.c =================================================================== --- channels/chan_zap.c (revision 16081) +++ channels/chan_zap.c (working copy) @@ -7922,7 +7922,6 @@ ZT_PARAMS param; int principle = -1; int explicit = PRI_EXPLICIT(channel); - span = PRI_SPAN(channel); channel = PRI_CHANNEL(channel); if (!explicit) { @@ -8834,14 +8833,11 @@ if (chanpos < 0) { ast_log(LOG_WARNING, "Ringing requested on unconfigured channel %d/%d span %d\n", PRI_SPAN(e->ringing.channel), PRI_CHANNEL(e->ringing.channel), pri->span); - chanpos = -1; - } - if (chanpos > -1) { + } else { chanpos = pri_fixup_principle(pri, chanpos, e->ringing.call); if (chanpos < 0) { ast_log(LOG_WARNING, "Ringing requested on channel %d/%d not in use on span %d\n", PRI_SPAN(e->ringing.channel), PRI_CHANNEL(e->ringing.channel), pri->span); - chanpos = -1; } else { ast_mutex_lock(&pri->pvts[chanpos]->lock); if (ast_strlen_zero(pri->pvts[chanpos]->dop.dialstr)) { @@ -8954,14 +8950,11 @@ if (chanpos < 0) { ast_log(LOG_WARNING, "Facility Name requested on unconfigured channel %d/%d span %d\n", PRI_SPAN(e->facname.channel), PRI_CHANNEL(e->facname.channel), pri->span); - chanpos = -1; - } - if (chanpos > -1) { + } else { chanpos = pri_fixup_principle(pri, chanpos, e->facname.call); if (chanpos < 0) { ast_log(LOG_WARNING, "Facility Name requested on channel %d/%d not in use on span %d\n", PRI_SPAN(e->facname.channel), PRI_CHANNEL(e->facname.channel), pri->span); - chanpos = -1; } else { /* Re-use *69 field for PRI */ ast_mutex_lock(&pri->pvts[chanpos]->lock); @@ -8978,14 +8971,11 @@ if (chanpos < 0) { ast_log(LOG_WARNING, "Answer on unconfigured channel %d/%d span %d\n", PRI_SPAN(e->answer.channel), PRI_CHANNEL(e->answer.channel), pri->span); - chanpos = -1; - } - if (chanpos > -1) { + } else { chanpos = pri_fixup_principle(pri, chanpos, e->answer.call); if (chanpos < 0) { ast_log(LOG_WARNING, "Answer requested on channel %d/%d not in use on span %d\n", PRI_SPAN(e->answer.channel), PRI_CHANNEL(e->answer.channel), pri->span); - chanpos = -1; } else { ast_mutex_lock(&pri->pvts[chanpos]->lock); /* Now we can do call progress detection */ @@ -9039,9 +9029,7 @@ if (chanpos < 0) { ast_log(LOG_WARNING, "Hangup requested on unconfigured channel %d/%d span %d\n", PRI_SPAN(e->hangup.channel), PRI_CHANNEL(e->hangup.channel), pri->span); - chanpos = -1; - } - if (chanpos > -1) { + } else { chanpos = pri_fixup_principle(pri, chanpos, e->hangup.call); if (chanpos > -1) { ast_mutex_lock(&pri->pvts[chanpos]->lock); @@ -9109,9 +9097,7 @@ if (chanpos < 0) { ast_log(LOG_WARNING, "Hangup REQ requested on unconfigured channel %d/%d span %d\n", PRI_SPAN(e->hangup.channel), PRI_CHANNEL(e->hangup.channel), pri->span); - chanpos = -1; - } - if (chanpos > -1) { + } else { chanpos = pri_fixup_principle(pri, chanpos, e->hangup.call); if (chanpos > -1) { ast_mutex_lock(&pri->pvts[chanpos]->lock); @@ -9169,9 +9155,7 @@ if (chanpos < 0) { ast_log(LOG_WARNING, "Hangup ACK requested on unconfigured channel number %d/%d span %d\n", PRI_SPAN(e->hangup.channel), PRI_CHANNEL(e->hangup.channel), pri->span); - chanpos = -1; - } - if (chanpos > -1) { + } else { chanpos = pri_fixup_principle(pri, chanpos, e->hangup.call); if (chanpos > -1) { ast_mutex_lock(&pri->pvts[chanpos]->lock); @@ -9228,9 +9212,7 @@ ast_log(LOG_WARNING, "Restart ACK requested on strange channel %d/%d span %d\n", PRI_SPAN(e->restartack.channel), PRI_CHANNEL(e->restartack.channel), pri->span); } - chanpos = -1; - } - if (chanpos > -1) { + } else { if (pri->pvts[chanpos]) { ast_mutex_lock(&pri->pvts[chanpos]->lock); if (pri->pvts[chanpos]->realcall)