Index: channels/chan_iax2.c =================================================================== RCS file: /usr/cvsroot/asterisk/channels/chan_iax2.c,v retrieving revision 1.338 diff -u -r1.338 chan_iax2.c --- channels/chan_iax2.c 1 Sep 2005 22:28:33 -0000 1.338 +++ channels/chan_iax2.c 2 Sep 2005 14:24:03 -0000 @@ -6579,6 +6579,15 @@ break; case IAX_COMMAND_QUELCH: if (iaxs[fr.callno]->state & IAX_STATE_STARTED) { + /* Generate Manager Hold event, if necessary*/ + if (iaxs[fr.callno]->owner) { + manager_event(EVENT_FLAG_CALL, "Hold", + "Channel: %s\r\n" + "Uniqueid: %s\r\n", + iaxs[fr.callno]->owner->name, + iaxs[fr.callno]->owner->uniqueid); + } + ast_set_flag(iaxs[fr.callno], IAX_QUELCH); if (ies.musiconhold) { if (iaxs[fr.callno]->owner && @@ -6587,8 +6596,17 @@ } } break; - case IAX_COMMAND_UNQUELCH: + case IAX_COMMAND_UNQUELCH: if (iaxs[fr.callno]->state & IAX_STATE_STARTED) { + /* Generate Manager Unhold event, if necessary*/ + if (iaxs[fr.callno]->owner && ast_test_flag(iaxs[fr.callno], IAX_QUELCH)) { + manager_event(EVENT_FLAG_CALL, "Unhold", + "Channel: %s\r\n" + "Uniqueid: %s\r\n", + iaxs[fr.callno]->owner->name, + iaxs[fr.callno]->owner->uniqueid); + } + ast_clear_flag(iaxs[fr.callno], IAX_QUELCH); if (iaxs[fr.callno]->owner && ast_bridged_channel(iaxs[fr.callno]->owner)) Index: channels/chan_sip.c =================================================================== RCS file: /usr/cvsroot/asterisk/channels/chan_sip.c,v retrieving revision 1.835 diff -u -r1.835 chan_sip.c --- channels/chan_sip.c 1 Sep 2005 23:01:54 -0000 1.835 +++ channels/chan_sip.c 2 Sep 2005 14:24:09 -0000 @@ -3458,32 +3458,12 @@ struct ast_frame af = { AST_FRAME_NULL, }; if (sin.sin_addr.s_addr && !sendonly) { ast_moh_stop(bridgepeer); - /* Indicate UNHOLD status to the other channel */ - ast_indicate(bridgepeer, AST_CONTROL_UNHOLD); - append_history(p, "Unhold", req->data); - if (callevents && ast_test_flag(p, SIP_CALL_ONHOLD)) { - manager_event(EVENT_FLAG_CALL, "Unhold", - "Channel: %s\r\n" - "Uniqueid: %s\r\n", - p->owner->name, - p->owner->uniqueid); - } - ast_clear_flag(p, SIP_CALL_ONHOLD); + /* Activate a re-invite */ ast_queue_frame(p->owner, &af); } else { /* No address for RTP, we're on hold */ - append_history(p, "Hold", req->data); - if (callevents && !ast_test_flag(p, SIP_CALL_ONHOLD)) { - manager_event(EVENT_FLAG_CALL, "Hold", - "Channel: %s\r\n" - "Uniqueid: %s\r\n", - p->owner->name, - p->owner->uniqueid); - } - ast_set_flag(p, SIP_CALL_ONHOLD); - /* Indicate HOLD status to the other channel */ - ast_indicate(bridgepeer, AST_CONTROL_HOLD); + ast_moh_start(bridgepeer, NULL); if (sendonly) ast_rtp_stop(p->rtp); @@ -3491,6 +3471,34 @@ ast_queue_frame(p->owner, &af); } } + + /* Manager Hold and Unhold events must be generated, if necessary */ + if (sin.sin_addr.s_addr && !sendonly) { + append_history(p, "Unhold", req->data); + + if (callevents && ast_test_flag(p, SIP_CALL_ONHOLD)) { + manager_event(EVENT_FLAG_CALL, "Unhold", + "Channel: %s\r\n" + "Uniqueid: %s\r\n", + p->owner->name, + p->owner->uniqueid); + + } + ast_clear_flag(p, SIP_CALL_ONHOLD); + } else { + /* No address for RTP, we're on hold */ + append_history(p, "Hold", req->data); + + if (callevents && !ast_test_flag(p, SIP_CALL_ONHOLD)) { + manager_event(EVENT_FLAG_CALL, "Hold", + "Channel: %s\r\n" + "Uniqueid: %s\r\n", + p->owner->name, + p->owner->uniqueid); + } + ast_set_flag(p, SIP_CALL_ONHOLD); + } + return 0; }