| Summary: | DAHTOOL-00091: configuration option for DAHLIN-395 | ||
| Reporter: | Sarah Autumn (spacegirl) | Labels: | patch |
| Date Opened: | 2022-02-02 12:15:36.000-0600 | Date Closed: | |
| Priority: | Minor | Regression? | |
| Status: | Triage/New | Components: | NewFeature |
| Versions: | 3.1.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | N/A | Attachments: | ( 0) DAHTOOL-91-hearpulsing.patch |
| Description: | This configuration option is coupled with issue DAHLIN-395 and will allow callers to select channels to hear audio during call setup. This configuration is done in system.conf
Also see https://gerrit.asterisk.org/c/asterisk/+/17948 | ||
| Comments: | By: N A (InterLinked) 2022-02-05 13:56:10.027-0600 I'm not sure to what extent the Asterisk style guidelines apply here, but a couple of things to note perhaps: 1) Use { } around if blocks, even when not necessary. Older code doesn't do that, but it's required for Asterisk additions now in new code and that may be a DAHDI policy as well. 2) Spaces are needed around the = and ; operators in for (x=0;x<DAHDI_MAX_CHANNELS;x++) {, per the style guidelines. Again, these are the Asterisk guidelines, but may apply to DAHDI as well; just thought I'd point that out. | ||