[Home]

Summary:DAHTOOL-00090: Missing time64 support (small issue)
Reporter:Sebastian Kemper (skemper)Labels:patch
Date Opened:2021-10-23 12:21:02Date Closed:
Priority:MinorRegression?
Status:Triage/NewComponents:Utilities
Versions:3.1.0 Frequency of
Occurrence
Related
Issues:
Environment:libc musl 1.2Attachments:( 0) 040-time64.patch
( 1) 040-time64-2.patch
( 2) 040-time64-3.patch
Description:libcs are implementing changes to fix the year 2038 issue on 32 bit platforms (see [1]). musl libc already went ahead and implemented it, starting with musl-1.2.0 (see [2]).

Compiling timertest.c now yields this warning:

timertest.c: In function 'main':
timertest.c:75:42: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'long long int' [-Wformat=]
  75 |                 printf("Timer Expired (%ld ms)!\n", (now.tv_sec - orig.tv_sec) * 1000 + (now.tv_usec - orig.tv_usec) / 1000);
     |                                        ~~^          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     |                                          |                                            |
     |                                          long int                                     long long int
     |                                        %lld
Comments:By: Sebastian Kemper (skemper) 2021-10-23 12:27:33.446-0500

Attached a patch for this. I tried to follow https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage, but when I type

git review -s

I get this:

No '.gitreview' file found in this repository. We don't know where
your gerrit is.
Please manually create a remote named "gerrit" or rename the default
one and try again.

By: Sebastian Kemper (skemper) 2021-10-23 12:31:42.697-0500

Ah, https://gerrit.asterisk.org/admin/repos/dahdi-linux seems to be empty.

I'll leave it at this.
By: Sebastian Kemper (skemper) 2021-11-01 06:53:56.936-0500

Hi all, this is an alternative patch, along the lines of patch set 4 in https://gerrit.asterisk.org/c/asterisk/+/16621
By: Sebastian Kemper (skemper) 2021-11-01 06:58:59.442-0500

Sorry, previously attached patch was the same as the first one. Here's the patch I wanted to upload.