| Summary: | DAHTOOL-00088: dahdi-tools, -Werror in xpp/oct612x/Makefile | ||
| Reporter: | Jaco Kroon (jkroon) | Labels: | |
| Date Opened: | 2021-01-08 08:47:50.000-0600 | Date Closed: | |
| Priority: | Trivial | Regression? | No |
| Status: | Triage/New | Components: | General |
| Versions: | 3.1.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Gentoo Linux. | Attachments: | |
| Description: | https://bugs.gentoo.org/751850
I'd recommend the -Werror only be added via DAHDI_DEVMODE_TRUE ... xpp/oct612x/Makefile:391 GLOBAL_CFLAGS = -Wall -Werror To be changed to take the value of DAHDI_DEVMODE into consideration, thus in Makefile.am, update the first line to: GLOBAL_CFLAGS = -Wall @DAHDI_DEVMODE_TRUE@GLOBAL_CFLAGS += -Werror Alternatively, follow the same patterns as the top level Makefile which makes use of an append structure for same. I'm certain other fixes are possible too, and I'm not sure what your preferred solution would be in this case. | ||
| Comments: | |||