Summary:	DAHTOOL-00085: dahdi-tools fails to build with -fno-common (enabled by default in gcc 10)
Reporter:	Jaco Kroon (jkroon)	Labels:	patch
Date Opened:	2020-03-16 03:00:46	Date Closed:
Priority:	Minor	Regression?	No
Status:	Triage/New	Components:	General
Versions:	3.1.0	Frequency of Occurrence	Constant
Related Issues:
Environment:	Gentoo Linux, gcc 10 (or -fno-common to older gcc)	Attachments:	( 0) dahdi-tools-3.1.0-fno-common.patch
Description:	https://bugs.gentoo.org/706832 I'll scope what's going on and submit a patch asap. {noformat} libtool: link: rm -fr .libs/libastribank.lax libtool: link: ( cd ".libs" && rm -f "libastribank.la" && ln -s "../libastribank.la" "libastribank.la" ) /bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include  -Wall  -O2 -pipe -march=native -fno-common -lusb-1.0  -Wl,-O1 -Wl,--as-needed -o astribank_tool astribank_tool-astribank_tool.o libastribank.la -lpthread -lm libtool: link: x86_64-pc-linux-gnu-gcc -I. -I./xtalk/include -Wall -O2 -pipe -march=native -fno-common -Wl,-O1 -o astribank_tool astribank_tool-astribank_tool.o  -Wl,--as-needed ./.libs/libastribank.a -lusb-1.0 -lpthread -lm /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ./.libs/libastribank.a(libxtalk_la-xtalk_sync.o):(.bss+0x0): multiple definition of `members'; ./.libs/libastribank.a(libastribank_la-mpptalk.o):(.bss+0x0): first defined here collect2: error: ld returned 1 exit status {noformat} Using grep these are the definitions: ./xpp/xtalk/xtalk_raw.c:} PACKED members; ./xpp/xtalk/xtalk_sync.c:} PACKED members; ./xpp/mpptalk.c:} PACKED members; I can't find that these are used anywhere though ...
Comments: