[Home]

Summary:DAHTOOL-00060: dahdi-tools fails to compile on Fedora 17 with kernel 3.4.4-3.fc17.x86_64 and gcc 4.7.0-5.fc17.x86_64
Reporter:Anthony Messina (amessina)Labels:
Date Opened:2012-07-06 11:34:28Date Closed:2013-03-15 16:04:36
Priority:MajorRegression?
Status:Closed/CompleteComponents:General
Versions:2.6.1 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dahdi-tools-2.6.1_DAHTOOL-60-f17.build.txt
( 1) DAHTOOL-60-f17.diff
Description:The following errors are encountered during the build:

{code}
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o hexfile.o hexfile.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o astribank_tool.o astribank_tool.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o astribank_usb.o astribank_usb.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o mpptalk.o mpptalk.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o xtalk/xtalk.o xtalk/xtalk.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o xtalk/xusb.o xtalk/xusb.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o xtalk/xlist.o xtalk/xlist.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk   -c -o xtalk/debug.o xtalk/debug.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api   -c -o astribank_hexload.o astribank_hexload.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api   -c -o pic_loader.o pic_loader.c
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api   -c -o echo_loader.o echo_loader.c
echo_loader.c: In function 'load_file':
echo_loader.c:374:7: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
gcc -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api -DPTR_TYPE=uint32_t -DcOCT6100_INTERNAL_SUPER_ARRAY_SIZE=1024 -DcOCT6100_MAX_ECHO_CHANNELS=672 -DcOCT6100_MAX_MIXER_EVENTS=1344 oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_channel.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_chip_open.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_chip_stats.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_debug.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_interrupts.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_memory.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_mixer.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_phasing_tsst.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_remote_debug.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tlv.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tone_detection.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsi_cnct.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c oct612x/apilib/bt/octapi_bt0.c oct612x/apilib/largmath/octapi_largmath.c oct612x/apilib/llman/octapi_llman.c
gcc -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -I. -Ixtalk -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api -Ioct612x/include -Ioct612x/octdeviceapi -Ioct612x/octdeviceapi/oct6100api -DPTR_TYPE=uint32_t -DcOCT6100_INTERNAL_SUPER_ARRAY_SIZE=1024 -DcOCT6100_MAX_ECHO_CHANNELS=672 -DcOCT6100_MAX_MIXER_EVENTS=1344 oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_channel.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_chip_open.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_chip_stats.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_debug.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_interrupts.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_memory.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_mixer.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_phasing_tsst.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_remote_debug.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tlv.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tone_detection.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsi_cnct.c oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c oct612x/apilib/bt/octapi_bt0.c oct612x/apilib/largmath/octapi_largmath.c oct612x/apilib/llman/octapi_llman.c
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c: In function 'Oct6100ApiBridgeEventRemove':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c:3870:47: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c:3870:47: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c: In function 'Oct6100EventGetToneDef':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:89:32: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:89:32: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c: In function 'Oct6100BufferPlayoutTransferEvents':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:1116:126: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c: In function 'Oct6100BufferPlayoutCheckForSpecificEvent':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:1287:29: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c: In function 'Oct6100ApiBridgeEventRemove':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c:3870:47: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.c:3870:47: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c: In function 'Oct6100EventGetToneDef':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:89:32: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:89:32: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c: In function 'Oct6100BufferPlayoutTransferEvents':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:1116:126: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c: In function 'Oct6100BufferPlayoutCheckForSpecificEvent':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.c:1287:29: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c: In function 'Oct6100ApiStrStr':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c:391:38: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c:391:38: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c:437:1: warning: control reaches end of non-void function [-Wreturn-type]
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c: In function 'Oct6100ApiStrStr':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c: In function 'Oct6100BufferPlayoutStopDef':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c:530:43: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c:530:43: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c:391:38: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c:391:38: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c: In function 'Oct6100ApiInvalidateChanPlayoutStructs':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c:2844:51: error: 'NULL' undeclared (first use in this function)oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.c:437:1: warning: control reaches end of non-void function [-Wreturn-type]
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c: In function 'Oct6100BufferPlayoutStopDef':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c:530:43: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c:530:43: note: each undeclared identifier is reported only once for each function it appears in
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c: In function 'Oct6100ApiInvalidateChanPlayoutStructs':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.c:2844:51: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c: In function 'Oct6100ApiReserveTsst':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c:401:29: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c:401:29: note: each undeclared identifier is reported only once for each function it appears in
oct612x/apilib/bt/octapi_bt0.c: In function 'OctApiBt0Init':
oct612x/apilib/bt/octapi_bt0.c:63:12: error: 'NULL' undeclared (first use in this function)
oct612x/apilib/bt/octapi_bt0.c:63:12: note: each undeclared identifier is reported only once for each function it appears in
oct612x/apilib/llman/octapi_llman.c: In function 'OctapiLlmAllocInit':
oct612x/apilib/llman/octapi_llman.c:88:12: error: 'NULL' undeclared (first use in this function)
oct612x/apilib/llman/octapi_llman.c:88:12: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [oct6100_adpcm_chan.o] Error 1
make[2]: *** Waiting for unfinished jobs....
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c: In function 'Oct6100ApiReserveTsst':
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c:401:29: error: 'NULL' undeclared (first use in this function)
oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.c:401:29: note: each undeclared identifier is reported only once for each function it appears in
oct612x/apilib/bt/octapi_bt0.c: In function 'OctApiBt0Init':
oct612x/apilib/bt/octapi_bt0.c:63:12: error: 'NULL' undeclared (first use in this function)
oct612x/apilib/bt/octapi_bt0.c:63:12: note: each undeclared identifier is reported only once for each function it appears in
oct612x/apilib/llman/octapi_llman.c: In function 'OctapiLlmAllocInit':
oct612x/apilib/llman/octapi_llman.c:88:12: error: 'NULL' undeclared (first use in this function)
oct612x/apilib/llman/octapi_llman.c:88:12: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [oct6100_channel.o] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/dahdi-tools-2.6.1/xpp'
make[1]: Leaving directory `/builddir/build/BUILD/dahdi-tools-2.6.1'
make[1]: *** [utils-subdirs] Error 2
make: *** [all] Error 2
{code}
Comments:By: Tzafrir Cohen (tzafrir) 2012-07-20 11:28:03.581-0500

Reproduced in trunk here. Thanks for the report.
By: Tzafrir Cohen (tzafrir) 2012-07-20 14:36:46.221-0500

A quick-fix for the issue. The proper fix should probably be elsewhere, though.
By: Anthony Messina (amessina) 2012-07-21 02:41:02.410-0500

The patch does allow compilation of dahdi-tools.  I'm attaching my build log here.
By: Anthony Messina (amessina) 2012-07-21 02:42:16.936-0500

Thanks Tzafrir.  I'm attaching my build log.  The patch does allow compilation.
By: Tuan Le (tuanle55) 2012-08-22 20:57:07.397-0500

Thanks for the patch.  I ran into the exact issue on FC17 on Dell R620 servers.  It worked to allow for compilations but is it a reliabile patch to use it in production or we should be rolling back to FC16 or a stable version for Fedora?  It patched xpp and confbridge of which I plan not to use these two items.
By: Shaun Ruffell (sruffell) 2012-08-23 23:37:29.742-0500

Tuan, The only change of significance was:

{noformat}
--- a/xpp/oct612x/include/octdef.h
+++ b/xpp/oct612x/include/octdef.h
@@ -39,6 +39,10 @@ $Octasic_Revision: 12 $
extern "C" {
#endif

+#ifndef __KERNEL__
+#include <stdio.h>
+#endif
+
{noformat}

The other change was just removing a blank line and probably was inadvertent and harmless. I feel it's safe for you to use that patch in production...as safe as using FC17 in production for a phone platform is anyway.

Generally though I recommend users stick with distributions with longer release cycles than Fedora Core for Asterisk servers.
By: Anthony Messina (amessina) 2013-01-29 08:45:55.633-0600

This patch has been working for for some time.  Is it ok to be included in the upstream source, or is there something that's being waited on?
By: Russ Meyerriecks (rmeyerriecks) 2013-01-29 10:09:21.955-0600

We are working on migrating dahdi-tools to git right now. Then a 2.6.2 release with this patch will follow. Thank you for your patience.
By: Anthony Messina (amessina) 2013-01-29 10:43:42.771-0600

That's great news!  Thanks again for the follow up, and the migration to git ;)
By: Malcolm Davenport (mdavenport) 2013-03-13 08:03:06.119-0500

Poster from [http://forums.asterisk.org/viewtopic.php?f=1&t=85985] indicates that this may not have made it into 2.6.2.  
By: Russ Meyerriecks (rmeyerriecks) 2013-03-13 14:09:35.088-0500

Your correct malcolm, this was missed when I tagged 2.6.2
By: Russ Meyerriecks (rmeyerriecks) 2013-03-13 15:46:00.703-0500

Patch is currently in dahdi-tools master and 2.6.y branches. Trying to figure out if a dahdi-tools 2.6.3 is necessary or if it can wait until 2.7. Comments?
By: Malcolm Davenport (mdavenport) 2013-03-13 15:48:42.846-0500

I'd go ahead and cut a 2.6.3.  It's a small fix with small risk, no?  And, fixing people now is better than waiting until 2.7 (some date in the future).
By: Russ Meyerriecks (rmeyerriecks) 2013-03-13 17:07:08.388-0500

Anthony,

Would you be willing to test the next release candidate? I've included this patch and would like to know if it fixes your issue before the next release.
You can download it with:
git clone git://git.asterisk.org/dahdi/tools dahdi-tools
git checkout v2.6.3-rc1
By: Anthony Messina (amessina) 2013-03-13 19:23:38.143-0500

Russ, I've been building RPMs for EL6 and Fedora 16, 17 and 18 with this patch since 2012-07-21: http://messinet.com/rpms/changeset/ee216d8/dahdi-tools/

I can confirm it works swimmingly for me in all of those environments and resolved this issue.
By: Russ Meyerriecks (rmeyerriecks) 2013-03-15 16:04:31.806-0500

Fixed in trunk and on 2.6.y branches. Distributed in 2.6.3-rc1 release