Summary:	DAHTOOL-00039: [patch] DAHDI 2.2.1, XPP and astribank_is_starting.c uses semtimedop() which is not supported in our uClibc.
Reporter:	abelbeck (abelbeck)	Labels:
Date Opened:	2010-02-06 08:37:35.000-0600	Date Closed:	2011-02-08 06:42:45.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) dahdi-tools-timeout.patch ( 1) dahdi-tools-timeout-v2.patch ( 2) dahdi-tools-timeout-v3.patch
Description:	DAHDI 2.2.1, XPP and astribank_is_starting.c uses semtimedop() which is not supported in our uClibc. I emailed an inquiry to Tzafrir Cohen, asking if semop() could be used instead of semtimedop() without a timeout.  Tzafrir noted that the (-t) timout option in astribank_is_starting is not longer used, so his response was "go for it".
Comments:	By: abelbeck (abelbeck) 2010-02-06 08:40:55.000-0600 Attached patch to remove timeout option in astribank_is_starting.c By: abelbeck (abelbeck) 2010-02-06 12:32:51.000-0600 Attached tweaked version of original patch. By: abelbeck (abelbeck) 2010-02-07 14:17:05.000-0600 Removed unused variable 't' in patch. By: abelbeck (abelbeck) 2010-02-08 11:53:48.000-0600 The dahdi-tools-timeout-v3.patch works for me. By: Tzafrir Cohen (tzafrir) 2010-02-22 06:26:03.000-0600 I just noticed that while the timeout parameter is not used, the timeout functionality is used. I would prefer to keep it. Time for an IFDEF, I guess. By: abelbeck (abelbeck) 2010-03-19 10:39:23 Our uClibc is now patched to add semtimedop() (thanks Philip Prindeville), so for our purposes this issue is solved on our end. By: Leif Madsen (lmadsen) 2010-07-27 13:22:56 Reporter this issue is resolved on his end -- what needs to be done next on this issue if anything? Does something need to be committed here or can this issue be closed out? By: Shaun Ruffell (sruffell) 2010-10-10 14:52:54 A similar issue was reported on the mailing list: http://thread.gmane.org/gmane.comp.telephony.pbx.asterisk.devel/43624 By: Digium Subversion (svnbot) 2010-10-17 13:41:27 Repository: dahdi Revision: 9426 U   tools/trunk/autoconfig.h.in U   tools/trunk/configure U   tools/trunk/configure.ac U   tools/trunk/xpp/astribank_is_starting.c ------------------------------------------------------------------------ r9426 | tzafrir | 2010-10-17 13:41:26 -0500 (Sun, 17 Oct 2010) | 9 lines astribank_is_starting: use semop if no semtimedop astribank_is_starting should use a timeout for the semaphore, but if the GNU-specific semtimedop() is not available, we'll just fall back to using semop with no time out. Not as good, but better than nothing. (closes issue DAHTOOL-39) Reported by: abelbeck ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=9426 By: Digium Subversion (svnbot) 2011-02-08 06:42:44.000-0600 Repository: dahdi Revision: 9736 _U  tools/branches/2.4/ U   tools/branches/2.4/autoconfig.h.in U   tools/branches/2.4/configure U   tools/branches/2.4/configure.ac U   tools/branches/2.4/xpp/astribank_is_starting.c ------------------------------------------------------------------------ r9736 | tzafrir | 2011-02-08 06:42:44 -0600 (Tue, 08 Feb 2011) | 12 lines astribank_is_starting: use semop if no semtimedop astribank_is_starting should use a timeout for the semaphore, but if the GNU-specific semtimedop() is not available, we'll just fall back to using semop with no time out. Not as good, but better than nothing. (closes issue DAHTOOL-39) Reported by: abelbeck Merged revisions 9426 via svnmerge from http://svn.digium.com/svn/dahdi/tools/trunk ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=9736