[Home]

Summary:DAHTOOL-00038: [patch] Dadhi-tools ignores linker flags when building utilities in xpp/
Reporter:Philip Prindeville (pprindeville)Labels:
Date Opened:2010-01-13 18:36:40.000-0600Date Closed:2010-03-07 01:45:17.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:General
Versions:2.2.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dahdi-tools-bugid16597.patch
( 1) dahdi-tools-bugid16597#2.patch
( 2) dahdi-tools-bugid16597#3.patch
Description:The value of $(LDFLAGS) is not used by xpp/Makefile when doing terminal link edit.

Example:

fpga_load: fpga_load.o hexfile.o
       $(CC) -L. -o $@ $^ $(EXTRA_LIBS) $(USB_LIB)

astribank_hexload: $(ABHEXLOAD_OBJS)
       $(CC) -L. -o $@ $(ABHEXLOAD_OBJS) $(EXTRA_LIBS) $(USB_LIB)

astribank_tool: $(ABTOOL_OBJS)
       $(CC) -L. -o $@ $(ABTOOL_OBJS) $(EXTRA_LIBS) $(USB_LIB)

astribank_allow: $(ABALLOW_OBJS)
       $(CC) -L. -o $@ $(ABALLOW_OBJS) $(EXTRA_LIBS) $(USB_LIB)

fpga_load.o: CFLAGS+=-D_GNU_SOURCE      # We use memrchr()

test_parse: test_parse.o hexfile.o
       $(CC) -L. -o $@ $^ $(EXTRA_LIBS) $(USB_LIB)


also, it's not clear that there's any value to using $(CC) to link instead of $(LD).
Comments:By: Philip Prindeville (pprindeville) 2010-01-13 19:45:30.000-0600

Tested, and seems to work.

At least the traces of doing a "make" seem sane.
By: Philip Prindeville (pprindeville) 2010-01-14 17:37:59.000-0600

Updated per the advice of the "autoconf" gurudom.
By: Philip Prindeville (pprindeville) 2010-03-03 14:05:05.000-0600

Alas, I get:

/home/philipp/alix/build_i586/staging_dir/bin/i586-linux-uclibc-ld --sysroot=/home/philipp/alix/build_i586/staging_dir -L/home/philipp/alix/build_i586/staging_dir/lib -L/home/philipp/alix/build_i586/staging_dir/usr/lib -L. -o astribank_tool astribank_tool.o astribank_usb.o mpp_funcs.o debug.o  -lusb
/home/philipp/alix/build_i586/staging_dir/bin/i586-linux-uclibc-ld: warning: cannot find entry symbol _start; defaulting to 0000000008048af8

when building.

Looks like crt0.o (or whatever) is being left out.
By: Philip Prindeville (pprindeville) 2010-03-03 15:09:54.000-0600

Ok, patch #3 seems to fix the _start issue.
By: Digium Subversion (svnbot) 2010-03-07 01:45:15.000-0600

Repository: dahdi
Revision: 8263

U   tools/trunk/configure.ac
U   tools/trunk/makeopts.in
U   tools/trunk/xpp/Makefile

------------------------------------------------------------------------
r8263 | tzafrir | 2010-03-07 01:45:14 -0600 (Sun, 07 Mar 2010) | 11 lines

Use LDFLAGS in the xpp Makefile

Use a more standard link command in the xpp Makefile.

(closes issue DAHTOOL-38)
Reported by: pprindeville
Patches:
     dahdi-tools-bugid16597#3.patch uploaded by pprindeville (license 347)
Tested by: pprindeville, tzafrir


------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=8263