[Home]

Summary:DAHTOOL-00035: [patch] Missing slash causes wrong file to be removed, which fails silently
Reporter:Philip Prindeville (pprindeville)Labels:
Date Opened:2009-08-30 01:57:52Date Closed:2009-11-04 10:41:51.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:General
Versions:2.2.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dahdi-tools-makefile.patch
Description:$(LIB_DIR) doesn't include a trailing slash, so one must be explicitly appended whenever it's used.

In this case, here:

rm -f $(DESTDIR)$(LIB_DIR)$(LTZ_SO)
Comments:By: Philip Prindeville (pprindeville) 2009-08-30 02:01:27

From a sample build:

/usr/bin/install -c -D -m 644 system.conf.sample /home/philipp/asterisk/build_i5
86/root/etc/dahdi/system.conf
/usr/bin/install -c -D -m 755 libtonezone.a /home/philipp/asterisk/build_i586/ro
ot/usr/lib/libtonezone.a
/usr/bin/install -c -D -m 755 libtonezone.so /home/philipp/asterisk/build_i586/r
oot/usr/lib/libtonezone.so.2.0
rm -f /home/philipp/asterisk/build_i586/root/usr/liblibtonezone.so
/bin/ln -sf libtonezone.so.2.0 \
               /home/philipp/asterisk/build_i586/root/usr/lib/libtonezone.so.2
/bin/ln -sf libtonezone.so.2.0 \
               /home/philipp/asterisk/build_i586/root/usr/lib/libtonezone.so


note the ..../usr/liblibtonezone.so
By: Digium Subversion (svnbot) 2009-09-15 11:54:35

Repository: dahdi
Revision: 7131

U   tools/trunk/Makefile

------------------------------------------------------------------------
r7131 | tzafrir | 2009-09-15 11:54:35 -0500 (Tue, 15 Sep 2009) | 7 lines

Add a missing trailing slash on the install-libs target

(closes issue DAHTOOL-35)
Reported by: pprindeville
Patches:
     dahdi-tools-makefile.patch uploaded by pprindeville (license 347)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=7131
By: Digium Subversion (svnbot) 2009-11-04 10:41:50.000-0600

Repository: dahdi
Revision: 7471

_U  tools/branches/2.2/
U   tools/branches/2.2/Makefile
U   tools/branches/2.2/dahdi_scan.c
U   tools/branches/2.2/doc/pattest.8
U   tools/branches/2.2/xpp/README.Astribank
U   tools/branches/2.2/xpp/astribank_tool.c
U   tools/branches/2.2/xpp/fpga_load.c
U   tools/branches/2.2/xpp/mpp_funcs.c
U   tools/branches/2.2/xpp/perl_modules/Dahdi/Xpp/Xpd.pm

------------------------------------------------------------------------
r7471 | tzafrir | 2009-11-04 10:41:48 -0600 (Wed, 04 Nov 2009) | 46 lines

Compilation and documentation fixes from trunk

Merged revisions 6842,6898,6902,6976,7131 via svnmerge from
http://svn.digium.com/svn/dahdi/tools/trunk

........
 r6842 | tzafrir | 2009-07-16 13:19:23 +0300 (Thu, 16 Jul 2009) | 2 lines
 
 Document attributes of a Dahdi::Xpp::Xpd object.
........
 r6898 | dbrooks | 2009-07-27 22:54:13 +0300 (Mon, 27 Jul 2009) | 6 lines
 
 Replaces typos "recieved" with "received" and "initilize" with "initialize".
 
 (closes issue ASTERISK-14522)
 Reported by: alecdavis
........
 r6902 | seanbright | 2009-07-28 00:05:16 +0300 (Tue, 28 Jul 2009) | 11 lines
 
 Pass correct channel number to DAHDI_GET_PARAMS when passing span numbers to dahdi_scan.
 
 When filtering, we weren't taking into account the number of channels in the spans that
 we were skipping.
 
 (closes issue DAHTOOL-33)
 Reported by: tony
 Patches:
       20090723_issue15553.patch uploaded by seanbright (license 71)
 Tested by: seanbright
........
 r6976 | tzafrir | 2009-08-12 22:21:01 +0300 (Wed, 12 Aug 2009) | 4 lines
 
 xpp: cleanup gcc warnings and one real astribank_tool bug
 
 xpp rev: 7281
........
 r7131 | tzafrir | 2009-09-15 19:52:58 +0300 (Tue, 15 Sep 2009) | 7 lines
 
 Add a missing trailing slash on the install-libs target
 
 (closes issue DAHTOOL-35)
 Reported by: pprindeville
 Patches:
       dahdi-tools-makefile.patch uploaded by pprindeville (license 347)
........

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=7471