| Summary: | DAHTOOL-00023: [patch] Text "maybe" missing | ||
| Reporter: | dovid (dovid) | Labels: | |
| Date Opened: | 2009-03-31 03:01:50 | Date Closed: | 2009-05-26 04:55:08 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | General |
| Versions: | 2.1.0.2 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ( 0) dahdi_hardware_nodev_make.diff ( 1) dahdi_hardware_nodevs.diff | |
| Description: | Upon running make menuconfig if you plan on using ztdummy maybe instead of saying "I think that the DAHDI hardware you have on your system is:" and then showing nothing the script should say that no hardware was found. ****** ADDITIONAL INFORMATION ****** [root@pita dahdi-tools-2.1.0.2]# make config install -D dahdi.init /etc/rc.d/init.d/dahdi /usr/bin/install -c -D -m 644 init.conf.sample /etc/dahdi/init.conf /usr/bin/install -c -D -m 644 modules.sample /etc/dahdi/modules /usr/bin/install -c -D -m 644 modprobe.conf.sample /etc/modprobe.d/dahdi /usr/bin/install -c -D -m 644 blacklist.sample /etc/modprobe.d/dahdi.blacklist install -D ifup-hdlc /etc/sysconfig/network-scripts/ifup-hdlc /sbin/chkconfig --add dahdi DAHDI has been configured. If you have any DAHDI hardware it is now recommended you edit /etc/dahdi/modules in order to load support for only the DAHDI hardware installed in this system. By default support for all DAHDI hardware is loaded at DAHDI start. I think that the DAHDI hardware you have on your system is: | ||
| Comments: | By: Tzafrir Cohen (tzafrir) 2009-04-01 18:28:04 Note that this was also the behaviour with Zaptel as well. But we can just add a line to the output of dahdi_hardware -v By: Tzafrir Cohen (tzafrir) 2009-04-09 12:57:55 New version of the patch: * Adapt patch to newer version of dahdi_hardware * actually run 'dahdi_hardware -v' from the makefile By: David Brooks (dbrooks) 2009-05-21 10:40:20 tzafrir, do you think the current patch is acceptable? I'll hand you the ball :) By: Tzafrir Cohen (tzafrir) 2009-05-25 09:51:13 A new version uploaded here until I figure how to deal with the reviewboard. Potential problems: * /dev/stderr may not be supported evrewhere. IT is tested to exist on Linux, OpenBSD and NetBSD. I wonder what about FreeBSD and Solaris. * There used to be a guy fanatical about getting the logic out of the Zaptel Makefile scriptlets :-) By: Digium Subversion (svnbot) 2009-05-26 04:55:07 Repository: dahdi Revision: 6657 U tools/trunk/Makefile ------------------------------------------------------------------------ r6657 | tzafrir | 2009-05-26 04:55:06 -0500 (Tue, 26 May 2009) | 11 lines Reword the message after 'make config' for the case no hardware found Check the output of dahdi_hardware and give a different message for the case it found no hardware. (closes issue DAHTOOL-23) Reported by: Dovid Patches: dahdi_hardware_nodev_make.diff uploaded by tzafrir (license 46) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=6657 | ||