Summary: | DAHTOOL-00020: [patch] dahdi.init can't unload module dahdi_dynamic_eth (module in use) | ||
Reporter: | Michael Ricordeau (tamiel) | Labels: | |
Date Opened: | 2009-03-04 05:44:58.000-0600 | Date Closed: | 2011-01-04 18:54:27.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Utilities |
Versions: | 2.1.0.2 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ( 0) 20090304_dahdi.init.patch | |
Description: | When using dahdi_dynamic_eth and doing dahdi.init stop (like /etc/init.d/dahdi stop), dahdi.init says "dahdi_dynamic_eth is in use". So, dahdi dynamic spans are always present. ****** STEPS TO REPRODUCE ****** /etc/init.d/dahdi stop Unloading DAHDI hardware modules: ERROR: Module dahdi_dynamic_eth is in use ERROR: Module dahdi_dynamic is in use by dahdi_dynamic_eth ERROR: Module dahdi is in use by dahdi_dynamic error. | ||
Comments: | By: Michael Ricordeau (tamiel) 2009-03-04 05:54:21.000-0600 Patch dahdi.init.patch is wrong (missing call to function shutdown_dynamic). Patch 20090304_dahdi.init.patch is ok. By: Digium Subversion (svnbot) 2009-03-05 15:10:07.000-0600 Repository: dahdi Revision: 6095 U tools/trunk/dahdi.init ------------------------------------------------------------------------ r6095 | tzafrir | 2009-03-05 15:10:07 -0600 (Thu, 05 Mar 2009) | 11 lines Fix a typo in shutting down dynamic spans in dahdi.init Fixes shutdown_dynamic() in the dahdi init.d script. Not enabling it by default just yet (the second half of the patch) until we get some further confirmation that such a shutdown is always good. (from issue DAHTOOL-20) Reported by: tamiel Patches: 20090304_dahdi.init.patch uploaded by tamiel (license 712) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=6095 By: Tzafrir Cohen (tzafrir) 2009-03-05 15:13:17.000-0600 Anybody with dynamic spans: please make sure you have the fixed dahdi.init. In it: please unrem the call to shutdown_dynamic. Please report if it does or does not {work,harm} By: Tzafrir Cohen (tzafrir) 2009-03-06 13:51:40.000-0600 Another small thing: I'd like to have a separate /etc/dahdi/dynamic.conf . And thus dahdi.init would run (just before checking for a span and potentially loading dahdi_dummy) if -r /etc/dahdi/dynamic.conf; then dahdi_cfg -c /etc/dahdi/dynamic.conf fi This should not break backward compatibility. However it should make it safe to just run dahdi_cfg eventually. By: Leif Madsen (lmadsen) 2009-09-08 14:13:13 Just thought I'd ping this old issue to see what is needed to reproduce and test this issue so we can get it closed out; or is there more work needed here before we could have this closed? By: Andrew Latham (lathama) 2010-12-09 16:11:48.000-0600 Appears to be fixed in 2.4.0 |