| Summary: | DAHTOOL-00010: Wildcard TE122 Card recognition problem | ||
| Reporter: | copas2 (copas2) | Labels: | |
| Date Opened: | 2008-12-11 07:34:08.000-0600 | Date Closed: | 2009-01-07 08:19:19.000-0600 |
| Priority: | Blocker | Regression? | No |
| Status: | Closed/Complete | Components: | General |
| Versions: | 2.1.0 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Dahdi tools can not recognize the Wildcard TE122 as an E1 card (if configured so by the jumper on the card) because it reads "Span 1: WCT1/0 "Wildcard TE122 Card 0" (MASTER) HDB3/CCS/CRC4 RED" as the card name ($head) in Span.pm. Problem seems to be that the T1 in "WCT1/0" confuses the tool and it reports that 31 channels are too many for a T1 span :-) After changing the wcT1 to someting else in the variable $head, it seems to be working fine. | ||
| Comments: | By: copas2 (copas2) 2008-12-11 07:52:19.000-0600 I've just seen your patch. It seems to work at the recogniton level. I recommend to place the corrected version under the official dahdi tools downloads. I've spent a lot of time with it and now I see that I could save it if I look here first. Why I didn't do it at first place because I thought that it's not a very young card and driver so it shoudn't be that kind of a bug. Fortunately it was... By: Tzafrir Cohen (tzafrir) 2008-12-11 16:03:59.000-0600 Err... currently Span.pm decides if a span is E1 or T1 according to the number of channels. What is the output of: cat /proc/dahdi/1 By: copas2 (copas2) 2008-12-12 01:05:45.000-0600 /proc/dahdi/1: Span 1: WCT1/0 "Wildcard TE122 Card 0" (MASTER) HDB3/CCS/CRC4 YELLOW RED IRQ misses: 1 1 WCT1/0/1 Clear RED (EC: MG2) 2 WCT1/0/2 Clear RED (EC: MG2) 3 WCT1/0/3 Clear RED (EC: MG2) 4 WCT1/0/4 Clear RED (EC: MG2) 5 WCT1/0/5 Clear RED (EC: MG2) 6 WCT1/0/6 Clear RED (EC: MG2) 7 WCT1/0/7 Clear RED (EC: MG2) 8 WCT1/0/8 Clear RED (EC: MG2) 9 WCT1/0/9 Clear RED (EC: MG2) 10 WCT1/0/10 Clear RED (EC: MG2) 11 WCT1/0/11 Clear RED (EC: MG2) 12 WCT1/0/12 Clear RED (EC: MG2) 13 WCT1/0/13 Clear RED (EC: MG2) 14 WCT1/0/14 Clear RED (EC: MG2) 15 WCT1/0/15 Clear RED (EC: MG2) 16 WCT1/0/16 HDLCFCS RED 17 WCT1/0/17 Clear RED (EC: MG2) 18 WCT1/0/18 Clear RED (EC: MG2) 19 WCT1/0/19 Clear RED (EC: MG2) 20 WCT1/0/20 Clear RED (EC: MG2) 21 WCT1/0/21 Clear RED (EC: MG2) 22 WCT1/0/22 Clear RED (EC: MG2) 23 WCT1/0/23 Clear RED (EC: MG2) 24 WCT1/0/24 Clear RED (EC: MG2) 25 WCT1/0/25 Clear RED (EC: MG2) 26 WCT1/0/26 Clear RED (EC: MG2) 27 WCT1/0/27 Clear RED (EC: MG2) 28 WCT1/0/28 Clear RED (EC: MG2) 29 WCT1/0/29 Clear RED (EC: MG2) 30 WCT1/0/30 Clear RED (EC: MG2) 31 WCT1/0/31 Clear RED (EC: MG2) By: Digium Subversion (svnbot) 2009-01-03 15:14:00.000-0600 Repository: dahdi Revision: 5626 U tools/trunk/xpp/perl_modules/Dahdi/Span.pm ------------------------------------------------------------------------ r5626 | tzafrir | 2009-01-03 15:14:00 -0600 (Sat, 03 Jan 2009) | 4 lines Dahdi::Span: Remove an over-general span header "pri" pattern. Should fix DAHTOOL-10 . ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=5626 By: Tzafrir Cohen (tzafrir) 2009-01-03 15:16:01.000-0600 copas2: I can't see any reason why the card will not be detected as T1. Could you please try latest dahdi-tools svn? Simply checkout trunk and run xpp/lsdahdi or xpp/dahdi_genconf from there. By: Tzafrir Cohen (tzafrir) 2009-01-03 15:19:45.000-0600 Err... you actually configured the card to be E1, and dahdi_genconf simply uses that information. Configure your card to be T1, and regenerate configuration. By: copas2 (copas2) 2009-01-06 13:03:21.000-0600 No, no, I configured it to E1 and with that patch I've found and mentioned above the tool reconizes the card perfectly. What I've attached as output was already the print out of the right working tool. About this patch which was made by you, I said, why wouldn't you merge it into the public code: --- xpp/perl_modules/Dahdi/Span.pm +++ xpp/perl_modules/Dahdi/Span.pm @@ -137,6 +137,7 @@ ); my @pri_strings = ( + '(?<!WC)(E1|T1|J1)', '(E1|T1|J1)', 'Tormenta 2 .*Quad (E1|T1)', # tor2. 'Digium Wildcard .100P (T1|E1)/', # wct1xxp By: Tzafrir Cohen (tzafrir) 2009-01-07 08:16:54.000-0600 Before removing that line, the pattern there happened to match to 'E1' from the string 'TE122'. And that implied that the span is E1. This is regardless of whether the span is actually E1 or T1. After removing it, it matches the pattern 'Wildcard TE122'. Whether it is E1 or T1 is determained by the number of channels in the span. (And yes, that place in the code has a FIXME note that J1 also has 24 channels. I have not encontered J1 or bug reports from someone with J1 yet). By: Tzafrir Cohen (tzafrir) 2009-01-07 08:19:18.000-0600 Closing. Please reopen this if this or any other related card is not detected. | ||