[Home]

Summary:DAHLIN-00401: gcc compiler warnings with 5.15 kernel
Reporter:N A (InterLinked)Labels:
Date Opened:2022-09-16 15:26:43Date Closed:
Priority:BlockerRegression?
Status:Triage/NewComponents:dahdi (the module)
Versions:3.1.0 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Ubuntu Server 22.04, 5.15 kernelAttachments:
Description:This is really for 3.2.0, the issue tracker hasn't been updated to include that yet.

Some additional compiler warnings with DAHDI Linux on 5.15:

{noformat}
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/base.o
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/base.c: In function ‘wctdm_check_battery_lost’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/base.c:1962:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
1962 |                 mod_hooksig(wc, mod, DAHDI_RXSIG_ONHOOK);
     |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/base.c:1964:9: note: here
1964 |         case BATTERY_PRESENT:
     |         ^~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/base.c: In function ‘wctdm_check_battery_present’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/base.c:2072:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
2072 |                 mod_hooksig(wc, mod, DAHDI_RXSIG_OFFHOOK);
     |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/base.c:2074:9: note: here
2074 |         case BATTERY_LOST:
     |         ^~~~
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/xhfc.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wctdm24xxp/wctdm24xxp.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/voicebus/voicebus.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/voicebus/GpakCust.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/voicebus/GpakApi.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/voicebus/voicebus_net.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/voicebus/vpmoct.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/voicebus/dahdi_voicebus.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wcb4xxp/base.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wcb4xxp/wcb4xxp.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xbus-core.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xbus-sysfs.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xbus-pcm.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xframe_queue.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpp_dahdi.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xproto.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_global.o
In file included from ./include/linux/kernel.h:19,
                from ./include/linux/list.h:9,
                from ./include/linux/module.h:12,
                from /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_global.c:23:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_global.c: In function ‘execute_chip_command’:
./include/linux/printk.h:450:44: warning: this statement may fall through [-Wimplicit-fallthrough=]
 450 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
     |                                            ^
./include/linux/printk.h:422:17: note: in definition of macro ‘printk_index_wrap’
 422 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
     |                 ^~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/dahdi_debug.h:38:9: note: in expansion of macro ‘printk’
  38 |         printk(KERN_ ## level "%s%s-%s: %s/%s: " fmt, #level, \
     |         ^~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/dahdi_debug.h:77:17: note: in expansion of macro ‘XPD_PRINTK’
  77 |                 XPD_PRINTK(NOTICE, "", xpd, fmt, ## __VA_ARGS__)
     |                 ^~~~~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_global.c:148:17: note: in expansion of macro ‘XPD_NOTICE’
 148 |                 XPD_NOTICE(xpd,
     |                 ^~~~~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_global.c:152:9: note: here
 152 |         case 'S':
     |         ^~~~
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/dahdi_debug.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpp.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_fxs.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpd_fxs.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_fxo.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpd_fxo.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_pri.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpd_pri.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_bri.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpd_bri.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/card_echo.o
 LD [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpd_echo.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/xpp_usb.o
 VERIFY  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/init_card_1_30
 VERIFY  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/init_card_2_30
 VERIFY  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/init_card_3_30
 VERIFY  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/init_card_4_30
 HOSTCC  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/print_fxo_modes.o
 HOSTLD  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/print_fxo_modes
 GEN     /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/init_fxo_modes
 CHECK   /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/xpp/init_card_2_30
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.o
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c: In function ‘__dahdi_hooksig_pvt’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:8482:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
8482 |                 if (chan->txstate != DAHDI_TXSTATE_OFFHOOK) break;
     |                    ^
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:8498:12: note: here
8498 |            case DAHDI_SIG_FXSGS:  /* FXS Groundstart */
     |            ^~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:8509:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
8509 |                 if (rxsig == DAHDI_RXSIG_START) {
     |                    ^
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:8517:12: note: here
8517 |            case DAHDI_SIG_FXOLS: /* FXO Loopstart */
     |            ^~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c: In function ‘dahdi_rbsbits’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:8614:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
8614 |                 if (!(cursig & DAHDI_BBIT)) {
     |                    ^
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:8619:13: note: here
8619 |             case DAHDI_SIG_EM_E1:
     |             ^~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c: In function ‘__dahdi_process_getaudio_chunk’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:7931:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
7931 |                         memset(txb + 1, txb[0], DAHDI_CHUNKSIZE - 1);
     |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:7933:17: note: here
7933 |                 case DAHDI_CONF_CONF:   /* Normal conference mode */
     |                 ^~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:7934:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
7934 |                         if (is_pseudo_chan(ms)) /* if pseudo-channel */
     |                            ^
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:7957:17: note: here
7957 |                 case DAHDI_CONF_CONFMON:        /* Conference monitor mode */
     |                 ^~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c: In function ‘__dahdi_process_putaudio_chunk’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:9052:28: warning: this statement may fall through [-Wimplicit-fallthrough=]
9052 |                         if (is_pseudo_chan(ms)) /* if a pseudo-channel */
     |                            ^
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-base.c:9067:17: note: here
9067 |                 case DAHDI_CONF_CONFANN:  /* Conference with announce */
     |                 ^~~~
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-sysfs.o
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-sysfs-chan.o
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-sysfs-chan.c: In function ‘fixed_devfiles_remove’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-sysfs-chan.c:384:17: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
 384 |                 if (d && !IS_ERR(d))
     |                 ^~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-sysfs-chan.c:40:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘i                             ’
  40 |         device_destroy(dahdi_class, MKDEV(DAHDI_MAJOR, num))
     |         ^~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-sysfs-chan.c:387:25: note: in expansion of macro ‘DEL_DAHDI_DEV’
 387 |                         DEL_DAHDI_DEV(fixed_minors[i].minor);
     |                         ^~~~~~~~~~~~~
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/dahdi-version.o
{noformat}

DAHDI Linux also no longer compiles on 5.19 kernel:
{noformat}
 CC [M]  /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp/base.o
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp/base.c: In function ‘t4_allocate_buffers’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp/base.c:3864:17: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration]
3864 |         alloc = pci_alloc_consistent(wc->dev, numbufs * T4_BASE_SIZE(wc) * 2,
     |                 ^~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp/base.c:3864:15: warning: assignment to ‘void *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
3864 |         alloc = pci_alloc_consistent(wc->dev, numbufs * T4_BASE_SIZE(wc) * 2,
     |               ^
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp/base.c: In function ‘t4_increase_latency’:
/usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp/base.c:3943:9: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration]
3943 |         pci_free_consistent(wc->dev, T4_BASE_SIZE(wc) * oldbufs * 2,
     |         ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:249: /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp/base.o] Error 1
make[2]: *** [scripts/Makefile.build:466: /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi/wct4xxp] Error 2
make[1]: *** [Makefile:1849: /usr/src/dahdi-linux-3.2.0-rc1/drivers/dahdi] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.19.0-051900-generic'
make: *** [Makefile:74: modules] Error 2
{noformat}
Comments: