| Summary: | DAHLIN-00393: DAHDI no longer compiles due to pcm-aspm | ||||
| Reporter: | N A (InterLinked) | Labels: | |||
| Date Opened: | 2021-10-08 06:24:26 | Date Closed: | 2022-02-10 10:54:49.000-0600 | ||
| Priority: | Major | Regression? | |||
| Status: | Closed/Complete | Components: | dahdi (the module) | ||
| Versions: | 3.1.0 | Frequency of Occurrence | Constant | ||
| Related Issues: |
| ||||
| Environment: | Debian 10, kernel 5.10 | Attachments: | |||
| Description: | DAHDI no longer compiles on any system I have tried, at least for one because it tries to include a header file which no longer exists in Linux:
root@pbxdev:/usr/src/dahdi-linux-3.1.0# make make -C drivers/dahdi/firmware firmware-loaders make[1]: Entering directory '/usr/src/dahdi-linux-3.1.0/drivers/dahdi/firmware' make[1]: Leaving directory '/usr/src/dahdi-linux-3.1.0/drivers/dahdi/firmware' make -C /lib/modules/5.10.0-8-amd64/build KBUILD_EXTMOD=/usr/src/dahdi-linux-3.1.0/drivers/dahdi DAHDI_INCLUDE=/usr/src/dahdi-linux-3.1.0/include DAHDI_MODULES_EXTRA=" " HOTPLUG_FIRMWARE=yes modules DAHDI_BUILD_ALL=m make[1]: Entering directory '/usr/src/linux-headers-5.10.0-8-amd64' scripts/Makefile.lib:12: 'hostprogs-y' is deprecated. Please use 'hostprogs' instead CC [M] /usr/src/dahdi-linux-3.1.0/drivers/dahdi/oct612x/oct612x-user.o In file included from /usr/src/dahdi-linux-3.1.0/drivers/dahdi/oct612x/oct612x-user.c:28: /usr/src/dahdi-linux-3.1.0/include/dahdi/kernel.h:62:10: fatal error: linux/pci-aspm.h: No such file or directory 62 | #include <linux/pci-aspm.h> | ^~~~~~~~~~~~~~~~~~ compilation terminated. make[4]: *** [/usr/src/linux-headers-5.10.0-8-common/scripts/Makefile.build:284: /usr/src/dahdi-linux-3.1.0/drivers/dahdi/oct612x/oct612x-user.o] Error 1 make[3]: *** [/usr/src/linux-headers-5.10.0-8-common/scripts/Makefile.build:501: /usr/src/dahdi-linux-3.1.0/drivers/dahdi/oct612x] Error 2 make[2]: *** [/usr/src/linux-headers-5.10.0-8-common/Makefile:1845: /usr/src/dahdi-linux-3.1.0/drivers/dahdi] Error 2 make[1]: *** [/usr/src/linux-headers-5.10.0-8-common/Makefile:185: __sub-make] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-5.10.0-8-amd64' make: *** [Makefile:74: modules] Error 2 root@pbxdev:/usr/src/dahdi-linux-3.1.0# Some discussion here of this header file being removed: https://github.com/mtorromeo/r8168/issues/19 Removing the header file doesn't make it compile, either. | ||||
| Comments: | By: Shaun Ruffell (sruffell) 2021-10-12 12:43:21.745-0500 This is a duplicate of DAHLIN-372 By: N A (InterLinked) 2021-10-12 15:55:51.164-0500 Yup, it is. I don't see all these new patches in the next branch on GitHub, but it's easy enough to manually apply the patch files for those diffs that have been made since 3.1.0. The only warnings I see now using official "next" are these, and they don't seem to prevent compilation from succeeding: dahdi_cfg.c: In function ‘are_all_spans_assigned’: dahdi_cfg.c:153:7: warning: ‘/span_count’ directive output may be truncated writing 11 bytes into a region of size between 0 and 1023 [-Wformat-truncation=] 153 | "%s/span_count", device_path); | ^~~~~~~~~~~ dahdi_cfg.c:152:2: note: ‘snprintf’ output between 12 and 1035 bytes into a destination of size 1023 152 | snprintf(attribute, sizeof(attribute) - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 153 | "%s/span_count", device_path); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ By: N A (InterLinked) 2022-02-10 10:54:49.392-0600 This issue has already been fixed in the next branch. | ||||