[Home]

Summary:DAHLIN-00359: DAHDI fails to build with kernel 4.15: init_timer / setup_timer
Reporter:Tzafrir Cohen (tzafrir)Labels:patch
Date Opened:2018-01-01 06:40:34.000-0600Date Closed:2019-05-31 09:20:00
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:General
Versions:2.10.0 Frequency of
Occurrence
Related
Issues:
is duplicated byDAHLIN-00361 Dahdi: incompatible pointer type error while building on fedora
is duplicated byDAHLIN-00362 Compilation fails against 4.15 - setup_timer() removed
Environment:Attachments:( 0) 0001-xpp-move-command_timer-functions-to-xbus-core.patch
( 1) 0002-fix-building-with-4.15-init_timer-setup_timer.patch
Description:Yet another change of interface: this time init_timer and setup_timer were removed in 4.15 . Attached a very initial patch that fixes building (though does not touch dahdi_dummy. Can we remove it?). And is also untested
Comments:By: Tzafrir Cohen (tzafrir) 2018-02-21 08:05:17.735-0600

Updated patch to fix an issue with the xpp driver: set timer data from pre-4.15 kernels.
By: Sean Darcy (seandarcy) 2018-02-28 16:22:42.075-0600

WFM. Fedora 26. kernel-4.15.4-200.fc26.x86_64.

Thanks,
By: Shaun Ruffell (sruffell) 2018-09-03 11:20:47.364-0500

I didn't search for this issue before looking at the same issue. But looking at the patch attached to this issue, I personally prefer to keeping just the new interface in the code and keeping the compatibility interface contained in include/dahdi/kernel.h.
By: Tzafrir Cohen (tzafrir) 2018-09-29 08:28:32.869-0500

Yes. I tried doing that. I can't think of a way to make that work. If you can figure a way to just use compatibility interfaces, go ahead.
By: Tzafrir Cohen (tzafrir) 2019-03-02 04:24:29.610-0600

Should be fixed with DAHDI 3.0.0, right?
By: Shaun Ruffell (sruffell) 2019-03-06 19:43:28.250-0600

That is my understanding (although I did run into another problem with RHEL 7.6 back porting setup_timer() which will need a patch).
By: Keith Morgan (kmorgan) 2019-05-31 09:19:48.478-0500

So kernels newer than 4.14 should now work with 3.0.0 and 5.x will work with 3.1.0