Summary:	DAHLIN-00324: Use request_firmware to load firmware for tor2 and pciradio
Reporter:	Tzafrir Cohen (tzafrir)	Labels:
Date Opened:	2013-06-01 04:17:37	Date Closed:	2019-05-31 09:53:02
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	pciradio tor2
Versions:	2.7.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) make-binary-bitfiles ( 1) pciradio-request_firmware ( 2) tor2-request_firmware
Description:	The drivers from the Zapata project (tor2 and pciradio) use firmware files: drivers/dahdi/pciradio.rbt and drivers/dahdi/tormenta2.rbt. The drivers are built to include in them a compiled version of those firmware files. These firmware files appear to be FPGA bitfiles or other firmware images.  Their headers refer to some source files. Thus the two modules (tor2.ko and pciradio.ko) that we build lack the complete sources and therefore cannot satisfy the requirements of the GPL. The standard way to handle such cases is to move the firmware to separate files and load them at run time. Ben Hutching, who originally reported this issue (see below), submitted a fix to have the drivers use request_firmware() to load the firmware files. Apart from that, all that is needed is to build the firmware files independently. Ben's patch should be uploaded here in the coming days, pending license and such. Original report: http://bugs.debian.org/693666
Comments:	By: Ben Hutchings (bwh) 2013-06-06 19:07:00.301-0500 Patch to make pciradio use request_firmware() By: Ben Hutchings (bwh) 2013-06-06 19:07:20.528-0500 Patch to make tor2 use request_firmware() By: Ben Hutchings (bwh) 2013-06-06 19:09:17.328-0500 Patch for makefw to generate binary files for use with request_firmware() By: Ben Hutchings (bwh) 2013-06-06 19:15:03.638-0500 There's one piece missing here which is to invoke makefw and install the bitfiles from drivers/dahdi/Makefile. For Debian, I implemented this in debian/rules though I can't remember quite why.