Summary:	DAHLIN-00301: Add W meta digit to pause 1 second while w meta digit pauses a half second.
Reporter:	Richard Mudgett (rmudgett)	Labels:
Date Opened:	2012-09-26 16:33:57	Date Closed:	2012-09-27 20:15:45
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	dahdi (the module)/NewFeature
Versions:		Frequency of Occurrence
Related Issues:	is related to DAHLIN-20039 DTMF meta-digit W missing
Environment:		Attachments:	( 0) diff_dahdi_linux_trunk.txt
Description:	Add 'W' as 1 second wait, to complement w as 500ms wait.
Comments:	By: Richard Mudgett (rmudgett) 2012-09-26 16:35:10.155-0500 [^diff_dahdi_linux_trunk.txt] adds the distinction between 'w' and 'W' pause durations. By: Richard Mudgett (rmudgett) 2012-09-26 16:37:26.434-0500 ASTERISK-20039 is the complementary issue for Asterisk that when the feature does not involve DAHDI. By: Shaun Ruffell (sruffell) 2012-09-26 18:58:02.189-0500 It appears like 'w' and 'W' have always been synonymous with a 0.5 second wait. Passing either will insert a 0.5 second pause since the dial string is always converted to upper case (in [r3490 "(merging dtmf-twister branch plus a few fixes)"|http://svnview.digium.com/svn/dahdi?view=revision&revision=3490] but still equivalent before that point). So this patch not only adds a new capability it also potentially changes the behavior of existing dial plans. Users who have capital "W" in their dial string right now will have the pause silently changed from a 0.5 second to 1 second wait. I would prefer to have a module parameter added that can allow users to "opt-in" to the new behavior. Is there anyone who would argue that a module parameter is a bad idea? By: Shaun Ruffell (sruffell) 2012-09-26 21:00:52.315-0500 Another passing thought: Is there any advantage to not leaving it completely under Asterisk's control?  I.e.  Asterisk could convert and 'W' characters to "ww" strings, essentially accomplishing the same function without changing DAHDI's interface? By: Russ Meyerriecks (rmeyerriecks) 2012-09-27 10:29:47.171-0500 +1 for Asterisk converting "W" to "ww". That way Asterisk can warn users of the modified behavior, otherwise Asterisk wouldn't know if the modparam would be set or not. Plus, less modparams are always nice. By: Richard Mudgett (rmudgett) 2012-09-27 20:15:19.462-0500 I agree that it is probably best to make Asterisk convert "W" to "ww".