[Home]

Summary:DAHLIN-00299: Will not build on 2.6.25.4
Reporter:Jean-Philippe Lord (jplord)Labels:
Date Opened:2012-08-16 15:04:53Date Closed:2012-08-16 16:43:38
Priority:MajorRegression?
Status:Closed/CompleteComponents:dahdi (the module)
Versions:2.6.1 Frequency of
Occurrence		Constant
Related
Issues:
Environment:Linux Kernel 2.6.25.4Attachments:
Description:Looks like include/kernel.h is incorrect with this statement:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 25)
#ifdef CONFIG_PCI
#include <linux/pci-aspm.h>
#endif
#endif

Compile error:

/asterisktest/dahdi-linux-complete-2.6.1+2.6.1/linux/include/dahdi/kernel.h:77:28: error: linux/pci-aspm.h: No such file or directory

I am not sure how to verify which 2.6.25 started to have pci-aspm.h but I know 2.6.25.4 does not.
Comments:By: Shaun Ruffell (sruffell) 2012-08-16 16:24:11.338-0500

Thanks for reporting this. Looks like a typo on my part.  Should be > KERNEL_VERSION(2,6,25) not >=.

Also, assuming you have a git copy of the kernel, here is how you could determine when a file went in:

{code}
$ git log --oneline --reverse -- include/linux/pci-aspm.h
7d715a6 PCI: add PCI Express ASPM support
5fde244 PCI: disable ASPM per ACPI FADT setting
2f671e2 PCI: Disable ASPM if BIOS asks us to
1a680b7 PCI: PCIe links may not get configured for ASPM under POWERSAVE mode
9f728f5 PCI/e1000e: Add and use pci_disable_link_state_locked()
3c07635 PCI: Rework ASPM disable code
$ git describe --contains 7d715a6
v2.6.26-rc1~1119^2~23
{code}

By: Shaun Ruffell (sruffell) 2012-08-16 16:43:38.089-0500

This was committed onto trunk in [r10705|http://svnview.digium.com/svn/dahdi?view=revision&revision=10705] and onto the 2.6 branch in [r10708|http://svnview.digium.com/svn/dahdi?view=revision&revision=10708] and will be in any commits after 2.6.1.

Thanks again.