[Home]

Summary:DAHLIN-00295: Silence tonezone
Reporter:Lelio della Pietra (leliodp)Labels:
Date Opened:2012-05-30 08:16:02Date Closed:2019-05-31 09:54:12
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:
Versions:2.6.1 Frequency of
Occurrence
Related
Issues:
is related toDAHLIN-19961 Completely silenced tone zone
Environment:Attachments:( 0) lelio.patch
Description:Sometimes it could be useful to have a "completely silenced" tonezone (both in DAHDI and indications.conf).

In my personal case, I manage a predictive dialer with AMI and it is useful to avoid the ring to the caller when the call, immediately after the answer, is redirected to an operator.
Comments:By: Shaun Ruffell (sruffell) 2012-05-30 10:06:27.321-0500

Interesting idea. I don't see any problems with adding a silence zone to dahdi tools. Is this something you would be able to generate a patch for?
By: Lelio della Pietra (leliodp) 2012-05-30 11:11:12.956-0500

In my old 2.3.0.1 version (my OpenVox driver is shipped as a patch to this old version) I added the following to zonedata.c (mutuated from "pa") and it works:

{
.zone = 43,
.country = "zz",
.description = "Silence",
.ringcadence = { 0, 0 },
.tones = {
{ DAHDI_TONE_DIALTONE, "0" },
{ DAHDI_TONE_BUSY, "0/320,0/320" },
{ DAHDI_TONE_RINGTONE, "0/1200,0/4650" },
{ DAHDI_TONE_CONGESTION, "0/320,0/320" },
{ DAHDI_TONE_CALLWAIT, "0/180,0/180,0/180" },
{ DAHDI_TONE_DIALRECALL, "!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,425" },
{ DAHDI_TONE_RECORDTONE, "0/500,0/15000" },
{ DAHDI_TONE_INFO, "!0/330,!0/330,!0/330,0" },
{ DAHDI_TONE_STUTTER, "!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,!0/100,425" },
},
.dtmf_high_level = -9,
.dtmf_low_level = -11,
.mfr1_level = -7,
.mfr2_level = -8,
},

I should access a more recent 2.6.0.1 B410P in next days and I'll complete the patch for 2.6.0.1. Just some suggestions:

a) is .zz a good choice for a non existant tonezone?
b) will a "0/0" be enough to silence a tone?


By: Shaun Ruffell (sruffell) 2012-05-30 11:48:42.188-0500

Lelio, could you attach this change as a patch to the issue after signing a License Agreement?  While in this case it's pretty straightforward, I am unable to apply any patches from contributors who have not [signed the agreement|https://issues.asterisk.org/jira/secure/DigiumLicense.jspa|].
By: Shaun Ruffell (sruffell) 2012-06-14 09:20:40.435-0500

Lelio, what do you think about using "none" for the country instead of "zz"?  I think that is more clear. Someone might need to look up what zz is, but I think if they saw "none" in the config file it would be clear.

Comments?
By: Lelio della Pietra (leliodp) 2012-06-14 09:26:24.646-0500

Yes, I think that "none" is definiitvely a better choice.


By: Shaun Ruffell (sruffell) 2014-04-11 11:31:50.596-0500

Lelio, did you want to update this patch for inclusion?
By: Lelio della Pietra (leliodp) 2014-04-19 02:28:37.502-0500

Shaun, no problem for me updating the patch, but I think that this patch is strictly related with the ASTERISK-19961 and makes no sense updating only one of them.
By: Shaun Ruffell (sruffell) 2014-04-22 09:13:27.655-0500

No complaints from me.