[Home]

Summary:DAHLIN-00274: dahdi_dummy fails to compile
Reporter:amcrory (amcrory)Labels:
Date Opened:2012-01-08 10:10:58.000-0600Date Closed:2012-03-15 11:02:22
Priority:MajorRegression?
Status:Closed/CompleteComponents:dahdi_dummy
Versions:2.6.0 Frequency of
Occurrence
Related
Issues:
Environment:CentOS 4.9 / kernel 2.6.9-103.plusAttachments:
Description:dahdi_dummy 2.5.0.2 compiles just fine on this system, however, version 2.6.0 fails with the following error

------
make MODULES_EXTRA="dahdi_dummy"
...
 CC [M]  /home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.o
/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.c: In function `dahdi_dummy_initialize':
/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.c:213: error: structure has no member named `devicetype'
/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.c:214: error: structure has no member named `devicetype'
/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.c:221: warning: implicit declaration of function `dahdi_register'
/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.c: In function `cleanup_module':
/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.c:276: warning: implicit declaration of function `dahdi_unregister'
make[2]: *** [/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi/dahdi_dummy.o] Error 1
make[1]: *** [_module_/home/maintainer/redhat/dahdi-linux-2.6.0/drivers/dahdi] Error 2
make[1]: Leaving directory `/usr/src/kernels/2.6.9-103.plus.c4.LSE.1-smp-i686'
make: *** [modules] Error 2
------


Comments:By: Shaun Ruffell (sruffell) 2012-01-08 13:18:50.021-0600

Is there a particular reason that you need to manually enable dahdi_dummy in the makefile?  DAHDI should no longer require dahdi_dummy on any supported kernel. The core if DAHDI now supports providing timing regardless of whether dahdi_dummy is loaded or not.

Also, I see that you're building on a 2.6.9 kernel. There was a [discussion|http://thread.gmane.org/gmane.comp.telephony.pbx.asterisk.devel/50063/focus=50126] about this recently on the asterisk-dev mailing list, and most likely support for 2.6.9 will be dropped in February of this year since it will be going into the extended support cycle for Redhat which, I believe, is the only current enterprise distribution that still provides support for 2.6.9.
By: amcrory (amcrory) 2012-01-08 20:45:08.296-0600

I realize this distribution is near EOL and it's not a big deal at this point. I just though I should report the error because it was a change in expected behavior. Thank you.

By: Shaun Ruffell (sruffell) 2012-01-08 22:31:11.152-0600

Just out of curiosity, is there a reason that you edit the Makefile in order to build DAHDI dummy instead of using the core timer?
By: amcrory (amcrory) 2012-01-09 05:35:31.067-0600

I have been building RPM packages for many years and this modification has been there as long. Old habits die hard.
By: Shaun Ruffell (sruffell) 2012-01-09 09:28:17.744-0600

Ok....and you're right, this is unexpected, so I'll patch it for trunk and the 2.6 branches.
By: amcrory (amcrory) 2012-01-09 10:50:01.942-0600

Sounds great. Thank you.
By: Shaun Ruffell (sruffell) 2012-03-15 11:02:22.073-0500

Fix committed onto trunk in [r10486|http://svnview.digium.com/svn/dahdi?view=revision&revision=10486]. It will be in 2.6.0.1 release.