Summary:	DAHLIN-00260: wctdm24xxp/base.c fails to compile in 2.6.16 kernel
Reporter:	Richard Miller (ulogic)	Labels:
Date Opened:	2011-10-13 19:38:19	Date Closed:	2011-10-22 15:06:39
Priority:	Major	Regression?	Yes
Status:	Closed/Complete	Components:	wctdm24xxp
Versions:	2.5.0.1	Frequency of Occurrence	Constant
Related Issues:
Environment:	OpenSuSE 10.1, 2.6.16.54 kernel	Attachments:	( 0) base.diff
Description:	drivers/dahdi/wctdm24xxp/base.c fails to compile.  CC [M]  /usr/src/packages/dahdi-linux-2.5.0.1/drivers/dahdi/wctdm24xxp/base.o /usr/src/packages/dahdi-linux-2.5.0.1/drivers/dahdi/wctdm24xxp/base.c: In function 'wctdm_fxs_hooksig': /usr/src/packages/dahdi-linux-2.5.0.1/drivers/dahdi/wctdm24xxp/base.c:2000: error: implicit declaration of function 'WARN_ON_ONCE' This can be fixed by using the same declarations used in lines 76-88 of drivers/dahdi/wctc4xxp/base.c
Comments:	By: Richard Miller (ulogic) 2011-10-13 19:40:55.720-0500 This definition was lifted from lines 76-88 of drivers/dahdi/wctc4xxp/base.c By: Shaun Ruffell (sruffell) 2011-10-17 09:15:39.957-0500 Any problem with moving that into include/dahdi/kernel.h?  Bonus points if you attach a git patch with a "Signed-off-by: " line.  But if you can't or don't want to no problems and I'll make the move. By: Richard Miller (ulogic) 2011-10-17 10:04:15.965-0500 Except for fixing this compilation issue, I have never previously examined any of the code in the DAHDI drivers.  It did not take a whole lot of detective work to come up with the fix.  I just used grep to find other instances of WARN_ON_ONCE.  It makes sense to put it in a common header file to avoid future compatibility problems.  When it comes to Linux development, I was pretty much a novice 3 months ago.  Prior to your last comment and doing a web search, I had not even heard of git.  Therefore, I will defer to you to move the definition to the headers. By: Shaun Ruffell (sruffell) 2011-10-22 15:06:39.909-0500 This same fix, added to include/dahdi/kernel.h is in 2.5.0.2.