Summary:	DAHLIN-00245: dahdi_dynamic slip issue with 2 or more TDMoE devices
Reporter:	Wagner Gegler (wagnermg)	Labels:
Date Opened:	2011-07-04 16:57:47	Date Closed:	2011-08-11 15:13:47
Priority:	Major	Regression?
Status:	Closed/Complete	Components:	dahdi_dynamic
Versions:		Frequency of Occurrence	Constant
Related Issues:
Environment:		Attachments:	( 0) 0001-dahdi_dynamic-Call-dahdi_receive-in-rx-packet-handle.patch ( 1) 0002-dahdi_dynamic-Call-dahdi_receive-in-rx-packet-handle.patch ( 2) dahdi_dynamic.patch ( 3) dahdi_dynamic.patch
Description:	With 2 or more TDMoE devices using dahdi_dynamic, there is a burst of skip/slip buffers on readchunk, due to jitter between read and write operations on this single buffer.
Comments:	By: Wagner Gegler (wagnermg) 2011-07-04 17:03:38.436-0500 This patch call dahdi_receive after readchunk is written (in dahdi_dynamic_receive), to prevent the skip/slip issue By: Shaun Ruffell (sruffell) 2011-07-19 10:08:29.134-0500 I'm just waiting for the license to clear in order to look at the patch. By: Wagner Gegler (wagnermg) 2011-07-27 09:36:18.574-0500 Reattaching the patch with license accepted By: Shaun Ruffell (sruffell) 2011-07-30 15:50:05.737-0500 Ahh...I think I see what you mean (although I haven't personally set this up and tested it...I do very little with dynamic_spans) I've attached a slightly edited version of your patch against trunk (just changed the ec_chunks to ec_span to save on disabling / enabling interrupts).  Would you be willing to test it (and also feel free to edit the commit message, adding your email address especially).  Once it goes into trunk I'll merge it into the 2.4 branch. By: Wagner Gegler (wagnermg) 2011-08-03 11:08:53.402-0500 I made a few changes on the patch: I filled my e-mail, change a little bit the commit message and remove the declaration of "y", that generates a warning (since is no longer used). I tested it on my setup, and it resolved the issue as expected. By: Shaun Ruffell (sruffell) 2011-08-06 09:53:51.223-0500 Thanks, I have it [queued up on my "for trunk"|https://github.com/sruffell/dahdi-linux/commit/1c52ef820620] branch which is here I store work waiting to go into trunk. As soon as the announcement for 2.5 goes out I'll commit it to trunk along with the other changes. Then it can be committed onto any needed branches from there. I'll close this issue when I have a link in svn to point to. By: Shaun Ruffell (sruffell) 2011-08-11 15:13:47.575-0500 Committed to trunk in [r10110|http://svnview.digium.com/svn/dahdi?view=revision&revision=10110], on the 2.4 branch in [r10113|http://svnview.digium.com/svn/dahdi?view=revision&revision=10113], and on the 2.5 branch in [r10116|http://svnview.digium.com/svn/dahdi?view=revision&revision=10116].