[Home]

Summary:DAHLIN-00242: [patch] hdlc_stats redifinition
Reporter:Pavel Selivanov (biohumanoid)Labels:
Date Opened:2011-05-24 05:13:16Date Closed:2011-06-02 15:01:07
Priority:MajorRegression?No
Status:Closed/CompleteComponents:dahdi (the module)
Versions:2.4.1.2 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 0001-dahdi-Fix-compilation-on-Linux-2.6.26-w-CONFIG_DAHDI.patch
Description:DAHDI will not compile with CONFIG_DAHDI_NET enabled with linux 2.6.26

hdlc_stats function was removed since linux 2.6.27, while DAHDI expect it was removed since 2.6.26.


****** ADDITIONAL INFORMATION ******

correct code:

#ifdef CONFIG_DAHDI_NET
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
static inline struct net_device_stats *hdlc_stats(struct net_device *dev)
{
return &dev->stats;
}
#endif
Comments:By: Shaun Ruffell (sruffell) 2011-05-24 10:40:21

biohumanoid: Attached a patch that is very slightly different. Would you like me to use your real name / email in the commit message?
By: Pavel Selivanov (biohumanoid) 2011-05-24 12:37:19

Sure, you can use my real name/email.
By: Digium Subversion (svnbot) 2011-06-02 15:01:06

Repository: dahdi
Revision: 9934

U   linux/trunk/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r9934 | sruffell | 2011-06-02 15:01:06 -0500 (Thu, 02 Jun 2011) | 13 lines

dahdi: Fix compilation on Linux 2.6.26 w/CONFIG_DAHDI_NET.

The hdlc_stats function was removed from the mainline kernel in commit
198191c4a7ce4daba379608fb38b9bc5a4eedc61 [1] which was first released in
linux 2.6.27.

[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=198191c4a7ce4

(closes issue DAHLIN-242)
Reported by: biohumanoid

Signed-off-by: Shaun Ruffell <sruffell@digium.com>
Acked-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9934