[Home]

Summary:DAHLIN-00236: [patch] core timer hangs if time goes back
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2011-03-29 10:00:29Date Closed:2011-04-04 11:24:28
Priority:MajorRegression?No
Status:Closed/CompleteComponents:dahdi (the module)
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 0001-core-timer-don-t-hang-when-the-clock-goes-back.patch
Description:This is a regression in trunk since r9407. If the time goes back ('date --set=12:34' if now is 12:36), coretimer_func will loop (almost) forever waiting for the timer to settle.
Comments:By: Shaun Ruffell (sruffell) 2011-03-29 10:45:45

"revrse" -> "reverse" but otherwise:

Acked-by: Shaun Ruffell <sruffell@digium.com>

I'll go ahead and mix this into my for-trunk tree now but I won't commit it.
By: Digium Subversion (svnbot) 2011-04-04 11:24:28

Repository: dahdi
Revision: 9876

U   linux/trunk/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r9876 | sruffell | 2011-04-04 11:24:27 -0500 (Mon, 04 Apr 2011) | 20 lines

core timer: don't hang when the clock goes back.

If the clock shifts back, don't hang in a loop of running
process_masterspan from the timer interrupt forever.

Fixes a regression of r9407.

(closes issue DAHLIN-236)
Reported by: tzafrir

Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>

After talking with Tzafrir on IRC, I combined the check if your far ahead
with the check if you're behind and added a '\n' at the end of the
existing "detected time shift" message.  That is why this patch is
different than what is posted on issue DAHLIN-236.

Acked-by: Shaun Ruffell <sruffell@digium.com>
Acked-by: Michael Spiceland <mspiceland@digium.com>
Acked-by: Kinsey Moore <kmoore@digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9876