Summary:	DAHLIN-00210: [patch] dahdi-linux fails to compile in ppp support if kernel ppp support compiled as a module
Reporter:	Jaco Kroon (jkroon)	Labels:
Date Opened:	2010-09-14 10:20:24	Date Closed:	2011-01-20 23:29:41.000-0600
Priority:	Trivial	Regression?	No
Status:	Closed/Complete	Components:	dahdi (the module)
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 07-config-ppp.diff ( 1) dahdi-config-ppp.diff
Description:	When compiling dahdi-linux I expect ppp support to be compiled in even if the kernel config has PPP configured as a module. ****** ADDITIONAL INFORMATION ****** This was tested with dahdi-linux-2.4.0.
Comments:	By: Jaco Kroon (jkroon) 2010-09-14 10:21:45 The patch I just attached changes the #ifdef to make use of #if defined() and tests whether either CONFIG_PPP or CONFIG_PPP_MODULE is defined, as per the already updated HDLC just above it. By: Jaco Kroon (jkroon) 2010-09-14 10:33:13 dahdi-config-ppp.diff is the correct patch.  I seem to have diff'ed from an intermediate source on the first one that contained a #error to ensure that it did in fact enable CONFIG_DAHDI_PPP. By: Digium Subversion (svnbot) 2010-09-14 11:34:10 Repository: dahdi Revision: 9328 U   linux/trunk/include/dahdi/dahdi_config.h ------------------------------------------------------------------------ r9328 | sruffell | 2010-09-14 11:34:09 -0500 (Tue, 14 Sep 2010) | 9 lines dahdi: Fix for when PPP support is compiled as a kernel module. When compiling dahdi-linux I expect ppp support to be compiled in even if the kernel config has PPP configured as a module. (closes issue DAHLIN-210) Reported by: jkroon Patches:      dahdi-config-ppp.diff uploaded by jkroon (license 714) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=9328 By: Digium Subversion (svnbot) 2010-09-21 11:16:01 Repository: dahdi Revision: 9392 U   linux/trunk/include/dahdi/dahdi_config.h ------------------------------------------------------------------------ r9392 | sruffell | 2010-09-21 11:16:01 -0500 (Tue, 21 Sep 2010) | 10 lines dahdi: Make CONFIG_DAHDI_PPP off by default. Before CONFIG_DAHDI_PPP can be on by default, some more work needs to be done to ensure that the ppp_generic module is not always loaded and that all channels do not carry around all the PPP members unnecessarily. (issue DAHLIN-210) Signed-off-by: Shaun Ruffell <sruffell@digium.com> Acked-by: Kevin P. Fleming <kpfleming@digium.com> ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=9392 By: Digium Subversion (svnbot) 2011-01-20 23:29:33.000-0600 Repository: dahdi Revision: 9669 U   linux/branches/2.4/include/dahdi/dahdi_config.h ------------------------------------------------------------------------ r9669 | sruffell | 2011-01-20 23:29:33 -0600 (Thu, 20 Jan 2011) | 11 lines dahdi: Fix for when PPP support is compiled as a kernel module. When compiling dahdi-linux I expect ppp support to be compiled in even if the kernel config has PPP configured as a module. (closes issue DAHLIN-210) Reported by: jkroon Patches:      dahdi-config-ppp.diff uploaded by jkroon (license 714) Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=9328 ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=9669 By: Digium Subversion (svnbot) 2011-01-20 23:29:41.000-0600 Repository: dahdi Revision: 9670 U   linux/branches/2.4/include/dahdi/dahdi_config.h ------------------------------------------------------------------------ r9670 | sruffell | 2011-01-20 23:29:41 -0600 (Thu, 20 Jan 2011) | 12 lines dahdi: Make CONFIG_DAHDI_PPP off by default. Before CONFIG_DAHDI_PPP can be on by default, some more work needs to be done to ensure that the ppp_generic module is not always loaded and that all channels do not carry around all the PPP members unnecessarily. (issue DAHLIN-210) Signed-off-by: Shaun Ruffell <sruffell@digium.com> Acked-by: Kevin P. Fleming <kpfleming@digium.com> Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=9392 ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=9670