[Home]

Summary:DAHLIN-00207: [patch] CONFIG_DAHDI_NET compiling error
Reporter:Mike Sinkovsky (msink)Labels:
Date Opened:2010-08-13 08:04:31Date Closed:2011-01-20 23:27:34.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:dahdi (the module)
Versions:2.3.0.1 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dahdi_net.patch
( 1) dahdi_net-v2.patch
Description:dahdi-base.c don't compiles in latest kernel if CONFIG_DAHDI_NET enabled
With this path it compiles and works:

=======
<sruffell: removed the patch pending license>
Comments:By: Shaun Ruffell (sruffell) 2010-08-13 09:46:02

I removed the patch from the note.  I'll look at it after the licensing step is done.
By: Mike Sinkovsky (msink) 2010-08-16 04:58:04

I don't know what is "licensing step". Isn't it GPL?
By: Shaun Ruffell (sruffell) 2010-08-16 08:46:49

Please see "The Contributor License Agreement" section at:
http://www.asterisk.org/developers/bug-guidelines

Once you've completed that step, I'll be able to look at the dahdi_net.patch you've submitted.  Thanks!
By: Mike Sinkovsky (msink) 2010-08-17 05:38:35

I did fill that form when attach file (actually file cannot be attached if form is not filled).
And the attach is labeled "[License OK (v3.0)]"
By: Shaun Ruffell (sruffell) 2010-08-17 07:13:14

Thanks for the patch.  Would you be willing to update it so that it works both when HAVE_NET_DEVICE_OPS is defined and when it's not?
By: Mike Sinkovsky (msink) 2010-08-18 03:57:29

Cleaned version of path uploaded.

Really this path fixes 3 independed problems:
1. function hdlc_stats was removed in kernel >= 2.6.26
2. HAVE_NET_DEVICE_OPS in kernel >= 2.6.28
3. unaligned access to ip address

Last problem is critical only on arch's when 32-bit word must be aligned on 32-bit boundary -- tested on AnalogDevices Blackfin, but should be on ARM too.
On x86 it is not critical.
By: Digium Subversion (svnbot) 2010-09-01 10:46:31

Repository: dahdi
Revision: 9247

U   linux/trunk/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r9247 | sruffell | 2010-09-01 10:46:30 -0500 (Wed, 01 Sep 2010) | 12 lines

dahdi: Fix compilation error when CONFIG_DAHDI_NET is defined.

Kernel interface for network devices changed. This is the patch from issue
plus a few trivial checkpatch.pl formatting changes (minus the >80 column
warnings).

(closes issue DAHLIN-207)
Reported by: msink
Patches:
     dahdi_net-v2.patch uploaded by msink (license 1103)

Signed-off-by: Shaun Ruffell <sruffell@digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9247
By: Digium Subversion (svnbot) 2011-01-20 23:27:34.000-0600

Repository: dahdi
Revision: 9655

U   linux/branches/2.4/drivers/dahdi/dahdi-base.c

------------------------------------------------------------------------
r9655 | sruffell | 2011-01-20 23:27:33 -0600 (Thu, 20 Jan 2011) | 14 lines

dahdi: Fix compilation error when CONFIG_DAHDI_NET is defined.

Kernel interface for network devices changed. This is the patch from issue
plus a few trivial checkpatch.pl formatting changes (minus the >80 column
warnings).

(closes issue DAHLIN-207)
Reported by: msink
Patches:
     dahdi_net-v2.patch uploaded by msink (license 1103)

Signed-off-by: Shaun Ruffell <sruffell@digium.com>

Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=9247
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9655