DAHLIN-00205: [patch] Prevent FXS Proslic Linefeed state from staying in "Forward/Reverse OnHookTransfer" during call

[Home]

Summary: DAHLIN-00205: [patch] Prevent FXS Proslic Linefeed state from staying in "Forward/Reverse OnHookTransfer" during call

Reporter: Alec Davis (alecdavis) Labels:

Date Opened: 2010-07-30 05:49:57 Date Closed: 2010-07-30 23:00:21

Priority: Minor Regression? No

Status: Closed/Complete Components: wctdm24xxp

Versions: Frequency of
Occurrence

Related
Issues:

Environment: Attachments: ( 0) wctdm_fxs_offhook.diff.txt
( 1) wctdm24xxp_fxs_offhook.diff.txt

Description: Now that the 3 second click after answering the call on an FXS port has been fixed, the side effect is that the Proslic during a call, still has the audio signal paths still powered on.

Reading the Si3215 specs it reads that an extra ~20mA is consumed while in OHT mode.

****** ADDITIONAL INFORMATION ******

This patch now immediately sets the SLIC_LF when off_hook is detected.

Comments: By: Alec Davis (alecdavis) 2010-07-30 06:16:14

debug output from dmesg:

Incorrectly setting LF state as we answer (from yesterday before patch)
[101823.408182] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 2 (04) intcount=92596
[101823.417951] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=24 lasttxhook=04 intcount=92602
[101823.809558] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 1 (02) intcount=92996
[101823.817951] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=42 lasttxhook=02 intcount=93002
[101824.010533] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 2 (04) intcount=93196
[101824.026535] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=14 lasttxhook=04 intcount=93202
[101824.030194] wctdm24xxp 0000:05:04.0: wctdm: Card 3 Going off hook
[101824.031335] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 1 (02) intcount=93207
[101824.031335] wctdm24xxp 0000:05:04.0: Channel 3 OnHookTransfer abort
[101824.039336] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=42 lasttxhook=02 intcount=93214
[101824.044172] wctdm24xxp 0000:05:04.0: wctdm: Card 3 Going on hook
[101824.048170] wctdm24xxp 0000:05:04.0: Channel 3 Set Reverse Polarity
[101824.052172] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=66 lasttxhook=06 intcount=93226
[101824.196034] wctdm24xxp 0000:05:04.0: wctdm: Card 3 Going off hook

Correctly setting the LF state as we answer (Today after patch).
[206463.554968] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 2 (04) intcount=551790
[206463.559110] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=24 lasttxhook=04 intcount=551794
[206464.075196] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 1 (02) intcount=552190
[206464.078049] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=42 lasttxhook=02 intcount=552194
[206466.418402] wctdm24xxp 0000:05:04.0: fxs_off_hook: Card 3 Going off hook
[206466.418430] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 1 (01) intcount=553914
[206466.418466] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=11 lasttxhook=01 intcount=553914
[206466.418500] wctdm24xxp 0000:05:04.0: Channel 3 OnHookTransfer abort
[206466.419207] wctdm24xxp 0000:05:04.0: Channel 3 Set Reverse Polarity
[206466.740868] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=55 lasttxhook=05 intcount=553922
[206466.762694] wctdm24xxp 0000:05:04.0: fxs_on_hook: Card 3 Going on hook
[206466.762754] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 0 (05) intcount=553946
[206466.762788] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=55 lasttxhook=05 intcount=553946
[206466.784626] wctdm24xxp 0000:05:04.0: fxs_off_hook: Card 3 Going off hook
[206466.784653] wctdm24xxp 0000:05:04.0: Setting FXS hook state to 1 (05) intcount=553966
[206466.784688] wctdm24xxp 0000:05:04.0: SLIC_LF OK: card=3 shadow=55 lasttxhook=05 intcount=553966

By: Shaun Ruffell (sruffell) 2010-07-30 14:05:20

Looks like the essential change is adding wctdm_fxs_hooksig into the wctdm_fxs_off_hook function? If so...I don't see any reason not to commit this.
By: Digium Subversion (svnbot) 2010-07-30 14:19:33

Repository: dahdi
Revision: 9070

U linux/trunk/drivers/dahdi/wctdm24xxp/base.c

------------------------------------------------------------------------
r9070 | alecdavis | 2010-07-30 14:19:33 -0500 (Fri, 30 Jul 2010) | 13 lines

wctdm24xxp: Prevent FXS Proslic staying in "Forward/Reverse OnHookTransfer" during call [One-liner summary of changes]

Now that the 3 second click after answering the call on an FXS port has been fixed, the side effect is that the Proslic during a call, still has the audio signal paths still powered on.

Reading the Si3215 specs it reads that an extra ~20mA is consumed while in OHT mode.

(closes issue DAHLIN-205)
Reported by: alecdavis
Patches:
wctdm24xxp_fxs_offhook.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9070
By: Digium Subversion (svnbot) 2010-07-30 23:00:21

Repository: dahdi
Revision: 9073

U linux/trunk/drivers/dahdi/wctdm.c

------------------------------------------------------------------------
r9073 | alecdavis | 2010-07-30 23:00:21 -0500 (Fri, 30 Jul 2010) | 15 lines

wctdm: Prevent FXS Proslic staying in "Forward/Reverse OnHookTransfer" during call

Since the 3 second click after answering the call on an FXS port has been fixed issue# 15352,
the side effect is that the Proslic during a call, still has the audio signal paths still powered on.

Reading the Si3215 specs it reads that an extra ~20mA is consumed while in OHT mode.

(issue DAHLIN-205)
Reported by: alecdavis
Patches:
wctdm_fxs_offhook.diff.txt uploaded by alecdavis (license 585)

Tested by: alecdavis

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9073