[Home]

Summary:DAHLIN-00191: [patch] usb_buffer_free/alloc renamed in 2.6.34; compat funcs dropped in 2.6.35-rc0
Reporter:Tony Vroon (chainsaw)Labels:
Date Opened:2010-05-24 11:16:56Date Closed:2010-06-08 14:46:15
Priority:MajorRegression?No
Status:Closed/CompleteComponents:dahdi (the module)
Versions:2.3.0 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 11-usb-buffer-free-has-a-new-name.diff
Description:usb_buffer_free/alloc were renamed in 2.6.34:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=073900a28d95c75a706bf40ebf092ea048c7b236

The compatibility wrappers put in place for 2.6.34 were dropped in 2.6.35-rc0:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e26bcf37234c67624f62d9fc95f922b8dbda1363

As such patching is required so that the new name is used on 2.6.34 and newer.
Comments:By: Tzafrir Cohen (tzafrir) 2010-05-24 13:27:32

A valid issue. I rather wait until a real RC is released, though.
By: Digium Subversion (svnbot) 2010-06-08 14:46:14

Repository: dahdi
Revision: 8762

U   linux/trunk/drivers/dahdi/xpp/xpp_usb.c

------------------------------------------------------------------------
r8762 | tzafrir | 2010-06-08 14:46:14 -0500 (Tue, 08 Jun 2010) | 11 lines

Use usb_{alloc,free}_coherent instead of usb_buffer_{alloc,free}.

usb_buffer_alloc has been replaced with usb_alloc_coherent , and likewise
usb_buffer_free has been replaced with usb_free_coherent. in kernels 2.6.34
the older names are proxies for the new ones, and in 2.6.35 the older names are gone.

This patch defines the new names for the old ones, for older kernel versions.

(closes issue DAHLIN-191)
Reported by: Chainsaw

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=8762