| Summary: | DAHLIN-00185: Dahdi dummy includes time.h, should be timer.h for low-res timer.... | ||
| Reporter: | Steve Murphy (murf) | Labels: | |
| Date Opened: | 2010-04-16 19:21:51 | Date Closed: | 2012-04-05 11:27:09 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | dahdi_dummy |
| Versions: | 2.2.1 | Frequency of Occurrence | |
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | It was reported that using older kernels would allow dahdi-dummy to be successfully compiled... A make failed on dahdi_dummy.c, with various timer funcs not being defined. I then spent some time and determined that the CONFIG_HIGH_RES_TIMERS was not set in .config in the kernel source, and that the include <linux/time.h> did not bring in the right stuff. I found that if I included <linux/timer.h> instead, that the make would complete, loaded fine, and tested (with dahdi_test -v) just fine also! So, this may signal that that in 2.6.32 and above, you may have to include timer.h instead of time.h; I have no idea if this is a new thing, or just not spotted before, or some weirdness in 2.6.32 alone. Or even just in this version of 2.6.32. Just giving a heads-up here. ****** STEPS TO REPRODUCE ****** This occurred while trying to build linux-2.6.32.1-rscloud. I have no idea if this is something unique to that tree, or whether things are getting shifted around in the 2.6.32+ versions of the kernel source. Or if just plain nobody is building kernels without CONFIG_HIGH_RES_TIMERS defined any more. If you need to know how to obtain this particular version of the kernel, let me know, I have some instructions that will allow you to download and build it. But, I suspect that if you've not spotted this in 2.6.32 and above, you may not have anything to worry about. Just letting you know. | ||
| Comments: | By: Shaun Ruffell (sruffell) 2012-04-05 11:27:09.594-0500 Thanks. Never could make the build fail, but you're right. I committed this change in [r10640|http://svnview.digium.com/svn/dahdi?view=rev&rev=10640] and onto the 2.6 branch in [r10644|http://svnview.digium.com/svn/dahdi?view=rev&rev=10644]. Thanks | ||