[Home]

Summary:DAHLIN-00179: fwringdetect option is ineffective
Reporter:Bob Eager (rde42)Labels:
Date Opened:2010-02-24 08:51:24.000-0600Date Closed:2011-01-20 23:30:15.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:wctdm24xxp
Versions:2.2.0.2 Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The fwringdetect option does not set registers correctly. This code, from line 2256 onwards, does not make sense:

if(fwringdetect || neonmwi_monitor) {
/* Enable ring detector full-wave rectifier mode */
wctdm_setreg(wc, card, 18, 2);
wctdm_setreg(wc, card, 24, 0);
} else {
/* Set to the device defaults */
wctdm_setreg(wc, card, 18, 0);
wctdm_setreg(wc, card, 24, 0x19);
}

/* Enable ring detector full-wave rectifier mode */
wctdm_setreg(wc, card, 18, 2);
wctdm_setreg(wc, card, 24, 0);

The last two statements nullify the 'if' statement above, since they repeat the settings in the 'true' branch.

The effect for me (in the UK) was that the card would not detect a ring condition. Removal of those two lines allowed ring to be detected.

****** ADDITIONAL INFORMATION ******

I actually noticed this on the BSD driver, but figured it would be better to report in the main branch.
Comments:By: Shaun Ruffell (sruffell) 2010-02-25 12:11:06.000-0600

That certainly doesn't look right.  I'll need to test it a bit before undoing that change since that it's the tested code path.
By: Digium Subversion (svnbot) 2010-10-20 07:23:03

Repository: dahdi
Revision: 9441

U   linux/trunk/drivers/dahdi/wctdm24xxp/base.c

------------------------------------------------------------------------
r9441 | sruffell | 2010-10-20 07:23:03 -0500 (Wed, 20 Oct 2010) | 15 lines

wctdm24xxp: Leave FXO (DAA) always in full-wave ring detect mode.

In zaptel commit 4096 [1], all the debouncing of ring signals were moved
into software as opposed to using the ring validation circuit in DAA.
That commit failed to remove the initial check and set of the ring
validation circuit.

[1] http://svn.digium.com/view/zaptel?view=revision&revision=4096

(closes issue DAHLIN-179)
Reported by: rde42

Signed-off-by: Shaun Ruffell <sruffell@digium.com>
Acked-by: Kinsey Moore <kmoore@digium.com>
Acked-by: Russ Meyerriecks <rmeyerriecks@digium.com>
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9441
By: Digium Subversion (svnbot) 2011-01-20 23:30:14.000-0600

Repository: dahdi
Revision: 9674

U   linux/branches/2.4/drivers/dahdi/wctdm24xxp/base.c

------------------------------------------------------------------------
r9674 | sruffell | 2011-01-20 23:30:14 -0600 (Thu, 20 Jan 2011) | 17 lines

wctdm24xxp: Leave FXO (DAA) always in full-wave ring detect mode.

In zaptel commit 4096 [1], all the debouncing of ring signals were moved
into software as opposed to using the ring validation circuit in DAA.
That commit failed to remove the initial check and set of the ring
validation circuit.

[1] http://svn.digium.com/view/zaptel?view=revision&revision=4096

(closes issue DAHLIN-179)
Reported by: rde42

Signed-off-by: Shaun Ruffell <sruffell@digium.com>
Acked-by: Kinsey Moore <kmoore@digium.com>
Acked-by: Russ Meyerriecks <rmeyerriecks@digium.com>

Origin: http://svnview.digium.com/svn/dahdi?view=rev&rev=9441
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=9674