[Home]

Summary:DAHLIN-00160: [patch] if, for, while, switch statements all missing space, - Coding guidelines
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2009-11-06 02:03:01.000-0600Date Closed:2009-12-16 12:58:48.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) dahdi-linux-if-for-when-switch.diff.txt
Description:Global change for all *.c and *.h files under the dahdi-linux tree where whole word matches any of the following.
'if(', 'for(', 'while(' or 'switch('

no functional changes
Comments:By: Tzafrir Cohen (tzafrir) 2009-11-06 14:45:34.000-0600

Note that The coding guidelines in question are http://kernel.org/doc/Documentation/CodingStyle

I just tried

 ~/Proj/Kernel/linux-2.6/scripts/checkpatch.pl --file --no-tree drivers/dahdi/dahdi-base.c

and got a long report containing:

 total: 907 errors, 840 warnings, 8475 lines checked
By: Shaun Ruffell (sruffell) 2009-11-06 14:52:07.000-0600

My personal opinion: We don't want to start reformatting for the sake of reformatting.  I've been operating that anything changes should bring things in line, but otherwise....
By: Digium Subversion (svnbot) 2009-12-16 12:58:47.000-0600

Repository: dahdi
Revision: 7702

_U  linux/trunk/build_tools/
A   linux/trunk/build_tools/kernel-cp

------------------------------------------------------------------------
r7702 | tzafrir | 2009-12-16 12:58:46 -0600 (Wed, 16 Dec 2009) | 8 lines

kernel-cp: a local wrapper to the kernel's checkpatch script.

checkpatch.pl is a script intended to check style of code (normally:
before submitting kernel patches).

As using this script simplifies testing new code for coding style,
this commit officially closes issue DAHLIN-160 .

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=7702