Summary: | DAHLIN-00140: [patch] race condition in handling writes to proslic LINEFEED register (64) | ||
Reporter: | Doug Bailey (dbailey) | Labels: | |
Date Opened: | 2009-09-10 16:20:22 | Date Closed: | 2009-09-14 15:53:31 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | wctdm24xxp |
Versions: | 2.2.0.2 | Frequency of Occurrence | |
Related Issues: | |||
Environment: | Attachments: | ( 0) 15875-wctdm24xxp.diff | |
Description: | Originally reported on asterisk-users by Barry Miller. The wctdm24xxp driver has a problem where a VMWI IOCTL call followed immediately by a ONHOOKTRANSFER IOCTL call will cause the ONHOOK transfer request to be dropped. This occurs if the write to the proslic's LINEFEED register for the VMWI ICTL call is not completed when the ONHOOK transfer request IOCTL is processed. ****** ADDITIONAL INFORMATION ****** This has been replicated using dahdi linux trunk (7085) and asterisk 1.6.1 (217036). | ||
Comments: | By: Doug Bailey (dbailey) 2009-09-10 16:24:02 This problem manifests itself when sending MWI FSK spills after a FXS channel goes on-hook or the channel's voicemail state changes. In this case, the spill never gets sent as the proslic is not properly placed into ONHOOKTRANSFER mode. By: Digium Subversion (svnbot) 2009-09-14 15:53:30 Repository: dahdi Revision: 7117 U linux/trunk/drivers/dahdi/proslic.h U linux/trunk/drivers/dahdi/wctdm24xxp/base.c U linux/trunk/drivers/dahdi/wctdm24xxp/wctdm24xxp.h ------------------------------------------------------------------------ r7117 | dbailey | 2009-09-14 15:53:30 -0500 (Mon, 14 Sep 2009) | 17 lines Race condition in handling writes to proslic LINEFEED register (64) The wctdm24xxp driver has a problem where a VMWI IOCTL call followed immediately by a ONHOOKTRANSFER IOCTL call will cause the ONHOOK transfer request to be dropped. This occurs if the write to the proslic's LINEFEED register for the VMWI ICTL call is not completed when the ONHOOK transfer request IOCTL is processed. I also cleaned out some magic numbers used in setting the linefeed register. (closes issue DAHLIN-140) Reported by: dbailey Patches: 15875-wctdm24xxp.diff uploaded by dbailey (license 819) Tested by: dbailey ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=7117 |