| Summary: | DAHLIN-00124: [patch] Making dahdi-linux generates superfluous error messages | ||
| Reporter: | Philip Prindeville (pprindeville) | Labels: | |
| Date Opened: | 2009-07-09 14:56:52 | Date Closed: | 2009-08-17 14:32:24 |
| Priority: | Trivial | Regression? | No |
| Status: | Closed/Complete | Components: | |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) dahdi-linux-rm.patch ( 1) Makefile.patch | |
| Description: | Dahdi-linux tries to remove /usr/include/zaptel. This is of questionable merit... but at the very least, it shouldn't generate errors on stderr. | ||
| Comments: | By: Tzafrir Cohen (tzafrir) 2009-08-03 12:15:21 I don't think I like the patch. Deleting the .h files is surprising enough. Nuking the whole directory may be a completely unpleasent surprise. We did not add it, so we should not remove it. By: Philip Prindeville (pprindeville) 2009-08-03 13:16:30 Well, someone added it, because it was already there. My patch just makes it not generate a warning message if it doesn't exist. By: Philip Prindeville (pprindeville) 2009-08-11 14:06:06 Please look again: the code *is* already in the source tree. I'm just changing the "rm" to an "rm -f" so it doesn't generate an error message if it isn't there. I'm not adding anything that wasn't there already. Just making it less error-prone. By: Philip Prindeville (pprindeville) 2009-08-11 15:26:53 Attached new patch: Don't use '-' rules, because those "Error 1 (ignored)" messages are really annoying... indeed, it's better form to avoid an error if you can't. Simplified things (don't need to "rm dir/* ; rmdir dir" when you can just "rm -rf dir" in one easy swoop). Made uninstalling the Zaptel headers its own target which must now be invoked explicitly. By: Digium Subversion (svnbot) 2009-08-17 14:32:23 Repository: dahdi Revision: 7027 U linux/trunk/Makefile ------------------------------------------------------------------------ r7027 | seanbright | 2009-08-17 14:32:23 -0500 (Mon, 17 Aug 2009) | 7 lines Silence spurious warnings when trying to remove Zaptel directories during install. (closes issue DAHLIN-124) Reported by: pprindeville Patches: dahdi-linux-rm.patch uploaded by pprindeville (license 347) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=7027 | ||