Summary:	DAHLIN-00120: [patch] Incorrect timing source validation (related to #13954)
Reporter:	Daniel Ferrer (dferrer)	Labels:
Date Opened:	2009-06-26 11:32:19	Date Closed:	2009-07-21 13:11:58
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	tor2
Versions:	2.2.0	Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) tor2-4th_sync.patch
Description:	Can't set a 4th timing source with tor2, dahdi_cfg fails with this error in dmesg: tor2 4: invalid span timing value 4. This is because a '>=' comparison between lc->sync and SPANS_PER_CARD (lc->sync = 4, SPANS_PER_CARD = 4). Comparison must be '>' strict to allow a 4th timing source (SPANS_PER_CARD = 4). This commit was added to correct timing source problems and adds the mentioned '>=' comparison: r5590 | tzafrir | 2008-12-19 06:39:26 -0600 (Fri, 19 Dec 2008) | 4 lines Related to DAHLIN-62 ****** ADDITIONAL INFORMATION ****** Using tor2 with 4 E1s: /etc/dahdi/system.conf span=1,1,0,ccs,hdb3 span=2,2,0,ccs,hdb3 span=3,3,0,ccs,hdb3 span=4,4,0,ccs,hdb3 dchan=16 bchan=1-15,17-31 dchan=47 bchan=32-46,48-62 dmesg (with patch): kernel: SPAN 1: Primary Sync Source kernel: SPAN 2: Secondary Sync Source kernel: SPAN 3: Tertiary Sync Source kernel: SPAN 4: Quaternary Sync Source withouth patch: kernel: SPAN 1: Primary Sync Source kernel: SPAN 2: Secondary Sync Source kernel: SPAN 3: Tertiary Sync Source kernel: tor3 4: invalid span timing value 4.
Comments:	By: Digium Subversion (svnbot) 2009-07-19 10:45:43 Repository: dahdi Revision: 6852 U   linux/trunk/drivers/dahdi/tor2.c ------------------------------------------------------------------------ r6852 | tzafrir | 2009-07-19 10:45:43 -0500 (Sun, 19 Jul 2009) | 12 lines tor2: allow using port4 as timing source Fix a silly regression introduced when strict check on the timing parameter was added (sync-1 is the array index, not sync itself. And 0 is a special case). (closes issue DAHLIN-120) Reported by: dferrer Patches:      tor2-4th_sync.patch uploaded by dferrer (license 525) ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=6852 By: Digium Subversion (svnbot) 2009-07-21 13:11:58 Repository: dahdi Revision: 6864 _U  linux/branches/2.2/ U   linux/branches/2.2/drivers/dahdi/dahdi-base.c U   linux/branches/2.2/drivers/dahdi/tor2.c U   linux/branches/2.2/drivers/dahdi/wct4xxp/base.c U   linux/branches/2.2/drivers/dahdi/wcte11xp.c U   linux/branches/2.2/drivers/dahdi/wcte12xp/base.c U   linux/branches/2.2/include/dahdi/dahdi_config.h ------------------------------------------------------------------------ r6864 | sruffell | 2009-07-21 13:11:56 -0500 (Tue, 21 Jul 2009) | 53 lines Merged revisions 6844,6852,6862-6863 via svnmerge from https://origsvn.digium.com/svn/dahdi/linux/trunk ........  r6844 | sruffell | 2009-07-16 12:29:53 -0500 (Thu, 16 Jul 2009) | 10 lines    wcte12xp: Disable vpmadt032 companding by default.    This fixes a regression in 2.2.0 where certain configurations will fail  patloop test or have repeated HDLC aborts because the VPMADT032 is modifying  the clear channel or d channel data streams.  This restores the behavior to  how it was in dahdi-linux 2.1.0.4.    (closes issue DAHLIN-126)  Reported by: alecdavis  Tested by: alecdavis ........  r6852 | tzafrir | 2009-07-19 10:45:40 -0500 (Sun, 19 Jul 2009) | 12 lines    tor2: allow using port4 as timing source    Fix a silly regression introduced when strict check on the timing  parameter was added (sync-1 is the array index, not sync itself. And 0  is a special case).    (closes issue DAHLIN-120)  Reported by: dferrer  Patches:        tor2-4th_sync.patch uploaded by dferrer (license 525) ........  r6862 | sruffell | 2009-07-21 12:52:59 -0500 (Tue, 21 Jul 2009) | 4 lines    Revert "wct4xxp, wcte11xp: Use the default configuration by default at startup."    This reverts the change introduced by revision 6712.  This change can cause  problems when there is a VPM module installed on the quad-span digital cards. ........  r6863 | sruffell | 2009-07-21 12:53:02 -0500 (Tue, 21 Jul 2009) | 12 lines    dahdi-base: Add support for core timing.    This essentially moves the function of dahdi_dummy into the core of DAHDI.  It  ensures that if DAHDI is loaded, it will always be able to provide timing,  regardless of whether there are board drivers loaded, or if the board drivers  are properly calling dahdi_receive.    If there is a master span loaded which is calling dahdi_receive, then the  behavior will be like it is normally.    This functionality is off by default, uncomment CONFIG_DAHDI_CORE_TIMER in  include/dahdi/config_dahdi.h in order to enable it. ........ ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=6864