[Home]

Summary:DAHLIN-00118: [patch] Kernal panic from dahdi_hooksig if JAPAN or AUDIO_RINGCHECK or ZERO_BATT_RING compile in
Reporter:Alec Davis (alecdavis)Labels:
Date Opened:2009-06-18 03:30:53Date Closed:2009-06-18 13:03:27
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:wctdm
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) wcfxo_dahdi_hooksig_panic.diff.txt
( 1) wctdm.c_dahdi_hooksig_panic.diff.txt
( 2) wctdm24xxp_dahdi_hooksig_panic.diff.txt
Description:While working on another patch dicovered this
dahdi_hooksig(&wc->chans[card], DAHDI_RXSIG_OFFHOOK);

Were in all the other dahdi_hooksig calls in the same function they are with the '&'.
dahdi_hooksig(wc->chans[card], DAHDI_RXSIG_OFFHOOK);



****** ADDITIONAL INFORMATION ******

Not much else to say. Other than easy karma for a serious bug :)
Comments:By: Alec Davis (alecdavis) 2009-06-18 03:51:10

Meant to say in description.

Where as in all the other dahdi_hooksig calls in the same function they are without the '&'.
dahdi_hooksig(wc->chans[card], DAHDI_RXSIG_OFFHOOK);
By: Digium Subversion (svnbot) 2009-06-18 13:03:27

Repository: dahdi
Revision: 6692

U   linux/trunk/drivers/dahdi/wcfxo.c
U   linux/trunk/drivers/dahdi/wctdm.c
U   linux/trunk/drivers/dahdi/wctdm24xxp/base.c

------------------------------------------------------------------------
r6692 | sruffell | 2009-06-18 13:03:26 -0500 (Thu, 18 Jun 2009) | 8 lines

wctdm, wctdm24xxp, wcfxo: Fix calls to dahdi_hooksig.

When JAPAN, AUDIO_RINGCHECK, or ZERO_BATT_RING compile time options are
selected it is possible to get a kernel panic due to an invalid pointer passed
to the dahdi_hooksig function.

(closes issue DAHLIN-118)
Patch by: alecdavis
------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=6692